Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multi-language data #18

Closed
Stimim opened this issue May 15, 2021 · 0 comments
Closed

Support multi-language data #18

Stimim opened this issue May 15, 2021 · 0 comments

Comments

@Stimim
Copy link
Collaborator

Stimim commented May 15, 2021

Try to support multi-language name / description, e.g.

{
  "name": {
    "zh-TW": "雲林東勢開安宮",
    "en-US": "Kai’an Temple"
  },
  "
}

When "name" is just a string, then we would just use it.
When current locale is not in "name", we can fallback to "en-US".
Stimim added a commit that referenced this issue May 15, 2021
@Stimim
support i18n dataset
e06b850 
Issue: #18
In dataset, we can have:

{
  ...,
  "name": {
    "zh-TW": "雲林東勢開安宮",
    "en-US": "Kai’an Temple"
  }
}

We will select based on current locale.
If current locale is not available, will use "en-US" as fallback.
@Stimim Stimim closed this as completed May 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Stimim