Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prop-types dependency is missing in package.json #75

Closed
Finesse opened this issue Mar 4, 2019 · 0 comments
Closed

prop-types dependency is missing in package.json #75

Finesse opened this issue Mar 4, 2019 · 0 comments
Assignees

Comments

@Finesse
Copy link

Finesse commented Mar 4, 2019

The library package requires prop-types when process.env.NODE_ENV !== 'production' and the prop-types package is not added to package.json. Therefore when I try to build my application using Webpack or Rollup, I get an error saying that the prop-types package is not found.

Version

1.3.2

Expected Behavior

The prop-types package is installed automatically or a peer dependency warning is shown when one installs the reactjs-popup package.

Actual Behavior

No warning is shown, the prop-types package is not installed and a bundling fails.

@yjose yjose self-assigned this Mar 4, 2019
@yjose yjose mentioned this issue May 11, 2019
@yjose yjose closed this as completed in 46a6e09 May 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants