Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError in custom connector. #21

Closed
cphyc opened this issue May 21, 2015 — with Huly GitHub · 1 comment
Closed

TypeError in custom connector. #21

cphyc opened this issue May 21, 2015 — with Huly GitHub · 1 comment

Comments

Copy link
Contributor

cphyc commented May 21, 2015

There seems to be an error in custom connector. In https://github.com/y-js/yjs/blob/master/lib/ConnectorClass.coffee#L113, you're pushing an array to @compute_when_synced whereas in https://github.com/y-js/yjs/blob/master/lib/ConnectorClass.coffee#L195 you expect a function !

I'm filling a PR for that.

Huly®: YJS-11

@cphyc cphyc mentioned this issue May 21, 2015
@dmonad
Copy link
Member

dmonad commented May 21, 2015

fixed by @cphyc

@dmonad dmonad closed this as completed May 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants