Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More robust test of the ~line keyword #3

Closed
yjunechoe opened this issue Oct 4, 2021 · 2 comments
Closed

More robust test of the ~line keyword #3

yjunechoe opened this issue Oct 4, 2021 · 2 comments
Labels
tests Tests
Milestone

Comments

@yjunechoe
Copy link
Owner

yjunechoe commented Oct 4, 2021

Should it be evaluated differently if the line involves assignment?

Does it break when you try to do assignment? (trace_exprs = { temp <- ~line })

@yjunechoe yjunechoe added the tests Tests label Oct 4, 2021
@yjunechoe
Copy link
Owner Author

This can actually get pretty ugly and I shouldn't really allow/encourage people to manipulate code beyond just referencing it.

If people really want to construct calls, they should just do that outside with result from ggbody(), grab the method environment with ggtrace() and last_ggtrace(), and simply do the evaluation after exiting the debugger.

I'm flipping this issue 180 degrees - if ~line is passed, it should be the only thing that's passed, otherwise it'll be evaluated like a normal expression

@yjunechoe yjunechoe added this to the v0.2.0 milestone Oct 4, 2021
@yjunechoe
Copy link
Owner Author

Moved to #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests
Projects
None yet
Development

No branches or pull requests

1 participant