Skip to content
This repository has been archived by the owner on Jan 20, 2024. It is now read-only.

feat: rewrite signup and signin page with tailwind UI #107

Merged

Conversation

olamide203
Copy link
Contributor

@olamide203 olamide203 commented Aug 20, 2022

Fixes

  • a rewrite of the signup and signing page with tailwind UI

Closes #100

📄 Note to reviewers

  • used react-icons for social media icons on signup and sign in page

📷 Screenshots

Screenshot 2022-08-20 at 15-54-53 Defaang

Screenshot 2022-08-20 at 15-54-28 Defaang

Screenshot 2022-08-20 at 16-04-58 Defaang

@vercel
Copy link

vercel bot commented Aug 20, 2022

Someone is attempting to deploy a commit to a Personal Account owned by @ykdojo on Vercel.

@ykdojo first needs to authorize it.

@vercel
Copy link

vercel bot commented Aug 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
defaang ✅ Ready (Inspect) Visit Preview Aug 22, 2022 at 9:07AM (UTC)

Copy link
Collaborator

@ykdojo ykdojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! It looks much better than what we had before, but I think the registration/signin box should be in a white background.

.env.template Show resolved Hide resolved
pages/signin.tsx Outdated Show resolved Hide resolved
pages/signin.tsx Outdated Show resolved Hide resolved
pages/signup.tsx Outdated Show resolved Hide resolved
pages/signup.tsx Outdated Show resolved Hide resolved
pages/signup.tsx Outdated Show resolved Hide resolved
pages/signup.tsx Outdated Show resolved Hide resolved
pages/signup.tsx Outdated Show resolved Hide resolved
pages/signin.tsx Outdated Show resolved Hide resolved
@olamide203
Copy link
Contributor Author

olamide203 commented Aug 20, 2022

I've made changes to the areas that were pointed out
also used the image from the code template in place of the former one

📷 Screenshots

Screenshot 2022-08-20 at 19-08-42 Defaang

@ykdojo
Copy link
Collaborator

ykdojo commented Aug 20, 2022

Thank you. The new UI has a lot of whitespace on the bottom, though:

image

Also, the "sign in with" options should be Google and GitHub - or we can comment them out for now.

pages/signup.tsx Outdated Show resolved Hide resolved
pages/signin.tsx Outdated Show resolved Hide resolved
pages/signin.tsx Outdated Show resolved Hide resolved
pages/signin.tsx Outdated Show resolved Hide resolved
@olamide203
Copy link
Contributor Author

Fixes

  • Removed extra space at the bottom of UI
  • Used react-icons for social icons
  • Replaced social signup options with google and github

@ykdojo
Copy link
Collaborator

ykdojo commented Aug 20, 2022

Thank you so much! It looks great.

A few minor things:

  1. I feel like the heading ("Sign in to your account") is slightly too thick?

That might be a styling thing - I might make a separate issue for it instead:

image

  1. Should we comment out the social logins/signups until we implement them?

@olamide203
Copy link
Contributor Author

  • The heading does look a bit wordy. I think just 'Sign in' should be okay.
  • we could also comment out the social logins/signups till they are implemented. I think there is an open issue addressing it.
    should I make a new PR with these changes?

@ykdojo
Copy link
Collaborator

ykdojo commented Aug 20, 2022

Yes! Thank you. I think you can just update this PR

@ykdojo
Copy link
Collaborator

ykdojo commented Aug 20, 2022

One more thing - let's remove the username field from the signup form.

image

Context: #95

@olamide203
Copy link
Contributor Author

what about the confirm password field? it not currently in use. should it be commented out till the feature gets implemented?

@ykdojo
Copy link
Collaborator

ykdojo commented Aug 21, 2022

Let's actually remove that one. I don't see a lot of websites using that field nowadays, and I don't think it's necessary.

pages/signin.tsx Outdated Show resolved Hide resolved
pages/signup.tsx Outdated Show resolved Hide resolved
pages/signin.tsx Outdated Show resolved Hide resolved
@olamide203 olamide203 requested review from ykdojo and rohitdasu and removed request for ykdojo and rohitdasu August 21, 2022 09:21
@olamide203 olamide203 requested review from iShibi, ykdojo and rohitdasu and removed request for iShibi and ykdojo August 21, 2022 09:21
@iShibi
Copy link
Contributor

iShibi commented Aug 22, 2022

Looks good to me. We can use some SignIn and SignUp components here to keep the pages tidy, what do you think?

@olamide203
Copy link
Contributor Author

olamide203 commented Aug 22, 2022

yea, both forms could be moved to separate components with a handleSubmit prop which would get called on submit. what are your thoughts on this?

@iShibi
Copy link
Contributor

iShibi commented Aug 22, 2022

I think this is ready to merge. In the next iteration, we can add options for usernames and socials. Just run npm run format:fix to resolve the prettier error and we are good to go.

@iShibi iShibi changed the title feat: rewrite signup and signin page with tailwind UI #100 feat: rewrite signup and signin page with tailwind UI Aug 22, 2022
@ykdojo
Copy link
Collaborator

ykdojo commented Aug 23, 2022

Since I have to interact with this part of the code as I work on #108, I'm going to merge it as is.

I might raise issues/propose fixes as I go.

@ykdojo ykdojo merged commit 83de475 into csdojo-defaang:main Aug 23, 2022
@olamide203 olamide203 deleted the feat/rewrite-sinup-with-tailwind-ui branch August 23, 2022 22:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] <Rewrite the signup/signin view with Tailwind UI>
5 participants