Skip to content
This repository has been archived by the owner on Jan 20, 2024. It is now read-only.

[FEATURE] <Make a signup/login view> #14

Closed
ykdojo opened this issue Aug 11, 2022 · 45 comments
Closed

[FEATURE] <Make a signup/login view> #14

ykdojo opened this issue Aug 11, 2022 · 45 comments
Labels
good first issue Good for newcomers

Comments

@ykdojo
Copy link
Collaborator

ykdojo commented Aug 11, 2022

Description

The first step in terms of dev/coding for this project is, I think, the signup/login view.

Signing up will be useful in case people want to associate their submission with their email address. In my opinion, it's important for people to have that option so that if the submission is not complete, we can go back and forth to make sure it's in a good enough state for us to feature on the website.

@ykdojo ykdojo added the good first issue Good for newcomers label Aug 11, 2022
@Swaraj-Singh-30
Copy link

Swaraj-Singh-30 commented Aug 11, 2022

Will give it try. Tech will be simple HYML, CSS and JS

Edited:- *Stack instead of tech

@ykdojo
Copy link
Collaborator Author

ykdojo commented Aug 11, 2022

@Swaraj-Singh-30 sounds good - thank you so much!!

@ykdojo ykdojo mentioned this issue Aug 11, 2022
@VaibhavSingh8
Copy link

Do you want the front end for login and signup?

@ykdojo
Copy link
Collaborator Author

ykdojo commented Aug 11, 2022

Yes! @Swaraj-Singh-30 might be making it though, I'm not sure.

@khanhtranngoccva
Copy link

How about ReactJS though @ykdojo? I have never seen projects with both plain-JS and ReactJS before. 😅

@ykdojo
Copy link
Collaborator Author

ykdojo commented Aug 12, 2022

Yes it'll be ideal to have it in React / Next.

But if someone submits something in plain JS, I think we can still use parts of it, especially if it uses Tailwind (which we're planning to use for this)

@Swaraj-Singh-30
Copy link

I'm not so familiar with next js actually. If someone wanna make it through next.js and tailwind I would say that you make it

@ykdojo if someone else is willing to do it I can step back. I am totally fine with that 😁

@ykdojo
Copy link
Collaborator Author

ykdojo commented Aug 12, 2022

@Swaraj-Singh-30 feel free to give it a try! we can convert it to Next.js + Tailwind later, too

@Swaraj-Singh-30
Copy link

Okay Yk 👍🏻🔥

@promisethedeveloper
Copy link

@ykdojo for the signup/logic form, would you want the user's information stored in a database yet? Or do you want the signup/login form without that functionality for now?

@ykdojo
Copy link
Collaborator Author

ykdojo commented Aug 12, 2022

Yes! We should start storing that info.

I think I’ll set up an account and a database in Supabase soon assuming we’ll go with it: #23

But anyone can set up their own instance, and assuming it looks good, I can replicate that in my account, too.

@ykdojo
Copy link
Collaborator Author

ykdojo commented Aug 12, 2022

A bit more info on what's to come next: #10 (comment)

@Jonyango
Copy link
Contributor

@Swaraj-Singh-30 @ykdojo I am familiar with Next.js and tailwind, and if you haven't started building, I can pick it up or provide some guidance.

@Swaraj-Singh-30
Copy link

Can you convert it into Next.js and tailwind?

@Jonyango
Copy link
Contributor

Can you convert it into Next.js and tailwind?

Yes

@jideabdqudus
Copy link
Contributor

I'll like to build the SignUp/Login using NextJS and AntD. Would this be a preferable stack?

@Preet-Sojitra
Copy link
Contributor

In my opinion first we should make only UI in Figma or any other software, if it gets approved, then we should code it, cause once the design is finalized then it will be more easy to code it.

@Swaraj-Singh-30
Copy link

In my opinion first we should make only UI in Figma or any other software, if it gets approved, then we should code it, cause once the design is finalized then it will be more easy to code it.

I'm working on it from yesterday, will publish it.

@ykdojo
Copy link
Collaborator Author

ykdojo commented Aug 12, 2022

I'll like to build the SignUp/Login using NextJS and AntD. Would this be a preferable stack?

any reason to use AntD over Tailwind?

@ykdojo
Copy link
Collaborator Author

ykdojo commented Aug 12, 2022

Note: now that #28 is merged, we should be able to use that as a starting point for this issue.

@jideabdqudus
Copy link
Contributor

I'll like to build the SignUp/Login using NextJS and AntD. Would this be a preferable stack?

any reason to use AntD over Tailwind?

Suggested AntD because of the amount of readily made components that could be used, Tailwind works too. But it's a preference

@Karthik-315
Copy link

Would it be ok, if I submit here, a Figma design for login / sign-up, here? I see that @Swaraj-Singh-30 is working on it, so don't want to interfere...

@ykdojo
Copy link
Collaborator Author

ykdojo commented Aug 13, 2022

Yes! I think @Swaraj-Singh-30 is working on a plain JS version, so it's ok to have a Figma, too

@Karthik-315
Copy link

Karthik-315 commented Aug 13, 2022

Cool! So here's a rough design I made: Figma Design. I've put in Login and Sign up in separate pages.

Take a look and feel free to let me know your suggestions. Also, if you need access to the file, let me know.

Edit: Added a dummy placeholder logo, that can be changed later.

@Preet-Sojitra
Copy link
Contributor

Cool! So here's a rough design I made: Figma Design. I've put in Login and Sign up in separate pages.

Take a look and feel free to let me know your suggestions. Also, if you need access to the file, let me know.

Edit: Added a dummy placeholder logo, that can be changed later.

Looks good 👍

@Sanskar-khandelwal
Copy link
Contributor

Cool! So here's a rough design I made: Figma Design. I've put in Login and Sign up in separate pages.

Take a look and feel free to let me know your suggestions. Also, if you need access to the file, let me know.

Edit: Added a dummy placeholder logo, that can be changed later.

Hey, everything looks super good, just a suggestion that back sign, Can be a little thin, try using a iconify icon instead of that

@Karthik-315
Copy link

Cool! So here's a rough design I made: Figma Design. I've put in Login and Sign up in separate pages.
Take a look and feel free to let me know your suggestions. Also, if you need access to the file, let me know.
Edit: Added a dummy placeholder logo, that can be changed later.

Hey, everything looks super good, just a suggestion that back sign, Can be a little thin, try using a iconify icon instead of that

Fair point, I've changed it with a slimmer one. Thanks for your suggestion!

@ykdojo
Copy link
Collaborator Author

ykdojo commented Aug 13, 2022

Looks good! I feel like we can experiment with different colors, though.

Also, I was thinking we can start with a light mode so it's more welcoming to everyone. What do you think?

@Preet-Sojitra
Copy link
Contributor

Yes starting with light mode is good idea, then at later stage we can add functionality of switching between dark and light mode

@Karthik-315
Copy link

Noted your points, will design for light mode too.

@Karthik-315
Copy link

Apart from color scheme, what is your opinion on the other elements, like the form elements and such, looks good?

@Swaraj-Singh-30
Copy link

Hello folks this is to inform y'all that since I won't be able to complete the login/sign up part, somebody else can take the part.

@ykdojo
Copy link
Collaborator Author

ykdojo commented Aug 13, 2022

@Karthik-315 I think everything else looks good!

@jideabdqudus
Copy link
Contributor

Hello folks this is to inform y'all that since I won't be able to complete the login/sign up part, somebody else can take the part.

What's the update on this? Is anyone working on it or I can pick it up?

@jideabdqudus
Copy link
Contributor

Cool! So here's a rough design I made: Figma Design. I've put in Login and Sign up in separate pages.

Take a look and feel free to let me know your suggestions. Also, if you need access to the file, let me know.

Edit: Added a dummy placeholder logo, that can be changed later.

Looks good mate, one thing I'll like to confirm is why is there a back sign on the auth screen, (especially on desktop mode) where does clicking on back lead to?

@Karthik-315
Copy link

The back button is just another way to navigate to the home page.

I think based on the design of the landing page, this can be removed, if there is a link to redirect to home page on the Navbar.

@ykdojo
Copy link
Collaborator Author

ykdojo commented Aug 14, 2022

Sounds good - I'm not sure about navbar, though. (No strong opinion either way right now)

@SrPanquesito
Copy link

Hello. I would like to contribute to the UI in this part as well.

@jideabdqudus can we work together on it?

@ykdojo
Copy link
Collaborator Author

ykdojo commented Aug 14, 2022

Cool! Keep in mind that there's this open PR, too: #64

But pls feel free to contribute where you see fit!

@SrPanquesito
Copy link

Cool! Keep in mind that there's this open PR, too: #64

But pls feel free to contribute where you see fit!

Thanks. I've just cloned his repo and saw the changes. It seems he's following a different design from the proposed one in this thread.

I was thinking about following the Figma Design but should I wait for his PR to be merged?

@ykdojo
Copy link
Collaborator Author

ykdojo commented Aug 14, 2022

Following the Figma design sounds good. #64 is good for now since we don't have a logo yet, though. It'll probably also needs some refining, too.

I think one option is to fork that PR and start making some progress there? Then once #64 is merged, then you can send your PR?

@Karthik-315
Copy link

I've also added a light mode option to the design.

If we all agree on a different color scheme later, this can be changed.

@BrajBliss
Copy link

Hey, is there anyone working on a Dark Mode right now?

@ykdojo
Copy link
Collaborator Author

ykdojo commented Aug 16, 2022

@vrindavan I don't think so? Unless @Karthik-315 is

Also we should decide on a dark mode color palette at #82

@ykdojo
Copy link
Collaborator Author

ykdojo commented Aug 17, 2022

I'm going to close this for now since we have working signup/login views.

@ykdojo ykdojo closed this as completed Aug 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests