Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a sign up form where the new user selects which language they are learning #39

Closed
ykdojo opened this issue Dec 5, 2018 · 24 comments

Comments

@ykdojo
Copy link
Owner

ykdojo commented Dec 5, 2018

We're going to start with just Japanese and English.

@ykdojo
Copy link
Owner Author

ykdojo commented Dec 6, 2018

I'm going to work on this next.

@ykdojo ykdojo self-assigned this Dec 6, 2018
@ykdojo
Copy link
Owner Author

ykdojo commented Dec 6, 2018

People should be able to select one of "both Japanese and English," "only Japanese", or "only English".

@ykdojo
Copy link
Owner Author

ykdojo commented Dec 6, 2018

UI text for this:

Select your languages

I'm learning...

  • Japanese or English, or both

I'm fluent in...

  • Japanese or English, or both (make this UI general enough so we can add more languages later)

NOTE: People need to select at least one language in each category.
Also add something like the following:

NOTE: It's currently only available for Japanese and English. If you want to practice writing in other languages, please sign up for our waiting list here: https://www.csdojo.io/wait

@ykdojo
Copy link
Owner Author

ykdojo commented Dec 6, 2018

Working on this now, as well as #41

@ykdojo
Copy link
Owner Author

ykdojo commented Dec 6, 2018

Made some bare UI at 1abbd84
image

@ykdojo
Copy link
Owner Author

ykdojo commented Dec 7, 2018

TODO Next: When someone selects English or Japanese, a plus sign should appear for people to select another language. (but not the same one twice)

@ykdojo
Copy link
Owner Author

ykdojo commented Dec 7, 2018

Also, TODO: We should fix the style a bit so it looks better.

@ykdojo
Copy link
Owner Author

ykdojo commented Dec 7, 2018

Just found this. I'm thinking of using it: https://developer.snapappointments.com/bootstrap-select/

@ykdojo
Copy link
Owner Author

ykdojo commented Dec 8, 2018

Experimented with it a little bit, and it looks really good. However, it looks like bootstrap-select and material-kit try to fight with each other when I try to use them at the same time. Will need to figure out a way to make them work at the same time.

@ykdojo
Copy link
Owner Author

ykdojo commented Dec 8, 2018

Okay, the problem is this:

In order for us to use bootstrap-select, we need to use the plain bootstrap CSS and JS files.

So, there's no easy way to use bootstrap-select and material-kit at the same time.

I still really like how material-kit looks, so I think I'll prioritize that.

Instead of using bootstrap-select, I'll add a bit of code so we can do multi-selecting.. At least that's my plan right now. Or maybe we can look for another multi-select library.

@ykdojo
Copy link
Owner Author

ykdojo commented Dec 8, 2018

People can now select multiple languages. (d6cd571)

image

Now we will have to:
A) Fix the style so it looks nicer
B) Write some backend code so people can actually sign up

@ykdojo
Copy link
Owner Author

ykdojo commented Dec 8, 2018

Oops. Actually, this code contained a bug. When you select Japanese and immediately change it to English, it keeps creating more and more select elements. Will need to fix it... maybe I'll take care of this tomorrow.

@ykdojo
Copy link
Owner Author

ykdojo commented Dec 8, 2018

Fixed it (1e47642). This works well now. We still need to fix the styles though-- will make this a new issue.

image

@ykdojo
Copy link
Owner Author

ykdojo commented Dec 8, 2018

Done. The new issue for fixing the looks of this is #45.

@ykdojo ykdojo closed this as completed Dec 8, 2018
@ykdojo
Copy link
Owner Author

ykdojo commented Dec 10, 2018

Actually, this is not quite done yet. Still need to make backend and database changes.

@ykdojo ykdojo reopened this Dec 10, 2018
@ykdojo ykdojo added the backend label Dec 10, 2018
@ykdojo ykdojo removed their assignment Dec 10, 2018
@ykdojo
Copy link
Owner Author

ykdojo commented Dec 11, 2018

Just started working on this.

@ykdojo ykdojo self-assigned this Dec 11, 2018
@ykdojo
Copy link
Owner Author

ykdojo commented Dec 11, 2018

Looks like we'll need to use fixtures to load initial language data.
https://docs.djangoproject.com/en/2.1/howto/initial-data/

@ykdojo
Copy link
Owner Author

ykdojo commented Dec 11, 2018

Just submitted these commits:

Will probably work on it some more tomorrow.

@ykdojo
Copy link
Owner Author

ykdojo commented Dec 11, 2018

TODO next: create a relationship between users and languages (each user can be fluent in one or more languages, as well as learning one or more languages)

@ykdojo
Copy link
Owner Author

ykdojo commented Dec 11, 2018

1a9fdfa

@ykdojo
Copy link
Owner Author

ykdojo commented Dec 11, 2018

Next: Connect the UI to the database so the user is able to select which languages they are learning / fluent in

@ykdojo
Copy link
Owner Author

ykdojo commented Dec 11, 2018

(NOTE: you can get learning_languages of a user with user.learning_languages, for example.)

@ykdojo
Copy link
Owner Author

ykdojo commented Dec 11, 2018

d3ac7dc

@ykdojo
Copy link
Owner Author

ykdojo commented Dec 12, 2018

Done for now: 6ea8ef2

Still need to fix the redirect that happens when the POST request is successful. I'll create a new issue for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant