Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor for DI and sample AP #5

Open
mrgfisher opened this issue Sep 14, 2021 · 1 comment
Open

Refactor for DI and sample AP #5

mrgfisher opened this issue Sep 14, 2021 · 1 comment

Comments

@mrgfisher
Copy link

This library is 'just what I'm looking for' and with a few tweaks I've got it working with the original ConsoleExample from rille111's version.

However I would like to tweak the flow relating to dependency injection, perhaps move to .net 5 and repurpose the console example as a reference app. What are your thoughts? I'm happy to take part as contributor, to discuss ideas via this thread, submit PR's or 'just leave it be' :-)

By way of context, my goal is around having a rich and configurable external rule based system for (amongst other things) lights that follow as you move around. Whilst HA is indeed amazing, it doesn't easily lend itself to the dynamic and reactive rules I have - hence shifting this to .Net.

@mrgfisher
Copy link
Author

mrgfisher commented Sep 19, 2021

@carldebilly - I've also added retry logic (general exceptions), web socket recreation for cleanly closed connections (e.g. HASS restart) and handling of the cancellation token. The changes are non-breaking and mostly within the StartReceive function of HassAppRunner. Let me know if you're open to a PR or (if easier) I'm very happy to be added as contributor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant