Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZInputStream ignores nowrap #6

Closed
saurik opened this issue Aug 19, 2012 · 3 comments
Closed

ZInputStream ignores nowrap #6

saurik opened this issue Aug 19, 2012 · 3 comments

Comments

@saurik
Copy link

saurik commented Aug 19, 2012

While there is a constructor on ZInputStream that takes a nowrap argument, it is not used to actually configure the underlying InflaterInputStream to support headerless compressed data.

@saurik
Copy link
Author

saurik commented Aug 19, 2012

Additionally, there is an init(nowrap) on Inflater (one that doesn't require you to manually pass the window size), but as there is no constructor on Inflater that takes only nowrap, you have to initialize it twice (or manually pass DEF_WBITS; I'm not certain which I consider more correct, but I'm currently going with the latter).

@saurik
Copy link
Author

saurik commented Aug 19, 2012

(Oh, but DEF_WBITS is private, so no: I guess the options are now either to hard-code that value--not entirely unreasonable, and often done in other environments like Python's zlib--or to double-initialize; I guess I'm now going to do the latter. ;P)

@ymnk
Copy link
Owner

ymnk commented Sep 6, 2012

Thank you for your feedback.
It has been fixed in
197205d
Please try it.

@ymnk ymnk closed this as completed Sep 10, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants