New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show tatoeba process #112
Show tatoeba process #112
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand the desire for progress information, but this does not look like the right approach to me. print()
prints to stdout without given users any control over it. Using Python's logging facility instead of print()
would help. Then, Audiomate is primarily a library. Using tqdm deep inside the library is not appropriate in my opinion because it forces tqdm upon everyone. Maybe there's a way to offer some sort of callbacks to make using tqdm an opt-in feature.
Regarding LL_WORD_TRANSCRIPT
, please open another pull request (separate discussion) and add a test if possible
Ok, i will move the LL_WORD_TRANSCRIPT commit to another branch. What about the updated comment, shall i make a third pull request for it? Regarding the tqdm and print suggestions, you are using both in the other files, for example here, so i thought it would be ok to use them too. |
In my opinion, you can do the comment together with Regarding tqdm/printing, I'm sorry that it hit you. Let's see what @ynop has to say. |
I added those things when I needed it. |
371b4e9
to
5f7efbf
Compare
I would suggest then we merge this with tqdm and print and you find a better way some other time:) |
Do you plan to implement a prediction for the time to completion in your logger? |
No plans so far. |
Could you merge the two commits? Afterwards I can merge it. |
Replace double quotes. Update to new logging infrastructure.
7b69a84
to
9ecc19e
Compare
Done. Why didn't you merge this before updating the logging? |
Because, I didn't think about that before merging the logging. |
I also changed the label type, because this solved a problem i had and the other datasets seemed to have LL_WORD_TRANSCRIPT as default and LL_WORD_TRANSCRIPT_RAW only optionally.