Merge all review tags into one

[EmberLightVFX]

Currently we have 3 different review tags. ftrackreview, shotgridreview and kitsureview.
I don't see a reason why we would have 3 different review tags instead of just one.

Maybe there are some extreme edge-case where a production uses two of theses review tools but I have never heard about it myself.
Thoughts?

[cuID:OP-5182]

[BigRoy]

Should we still somehow keep a review-upload (just as example; replacement for the 3 tags you mentioned) tag separate from review itself? Or should we just always upload a review by default?

[EmberLightVFX]

Should we still somehow keep a review-upload (just as example; replacement for the 3 tags you mentioned) tag separate from review itself? Or should we just always upload a review by default?

That's a good question.

I myself have never bin in a situation where I haven't uploaded a review file so I would say always upload a review.

What about you?

[Tilix4]

IMO review is sufficient. Review means "to be looked at by who is supposed to", therefore it must be uploaded to every production tracker we enabled.

[iLLiCiTiT]

Just to note, we have use-cases when something is marked as review so ExtractReview can create outputs but not all outputs are uploaded to "manager". So I disagree that "review" and "ftrackreview" are interchangeable.

Ad merging them, I think that @mkolar have an opinion on that front.

[EmberLightVFX]

I can see that the solo review tag should separated but ftrackreview, shotgridreview and kitsureview could be merged into one. Maybe rename it to something like Upload to review platform to really show what the tag does.

[Tilix4]

Things are becoming clearer 🥳 I'd have proposed the same thing as @EmberLightVFX did.

[BigRoy]

If I understand correctly then the current conclusion is that having "review" + "review upload" separate should be fine.
We could also instead say that "review" is the upload, and there's a "create-reviewable" tag or something.

If there's a better preference than review + review-upload tags let me know @mkolar so I can maybe try and tweak the #4757 PR accordingly.

[EmberLightVFX]

create-reviewable and review upload sounds good to me

[iLLiCiTiT]

Note: If we'll do any of these changes it should go to release branch and not to develop.

[Tilix4]

I suggest tags should have different syntax from families, therefore @EmberLightVFX's proposal looks perfect to me (not having a review tag, which is very confusing)

[BigRoy]

@mkolar are you able to share your thoughts about this?

[mkolar]

I'd agree that having review in tags and in families is confusing. So changing tag review to create-reviewable has some merit. Even though I'm not sure it's enough to justify the change that has a potential to break a lot of things if we're not extremely careful. even then, I'd argue that it should then be even more generic. For example transcode, considering that's what's actually happening in the extract review plugin that is interested in the tag.

Merging the three other tag, however, I don't think is a good idea. It's being less specific and assumes too much. We're at the start of syncsketch integration for example and will probably add others later, frame.io, vimeo, whatever. Suddenly it make perfect sense to upload one review output to ftrack (internal review with burnins), but another output to syncsketch for a client review with different burnins, or with watermark.

Point being. If we want to tell individual outputs where they should ultimately appear, we can't just assume its always project management.

[mkolar]

Guys this might seem like its simplifying something, but it would take functionality that is crucial at the moment away. Hence I'm moving it to discussions for posterity, but don't see it as an issue.