Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Houdini: OCIO support #4836

Closed
2 tasks done
antirotor opened this issue Apr 12, 2023 · 5 comments
Closed
2 tasks done

Houdini: OCIO support #4836

antirotor opened this issue Apr 12, 2023 · 5 comments
Labels
host: Houdini type: enhancement Enhancements to existing functionality

Comments

@antirotor
Copy link
Member

antirotor commented Apr 12, 2023

Is there an existing issue for this?

  • I have searched the existing issues.

Please describe the feature you have in mind and explain what the current shortcomings are?

We need to enhance OCIO support of AYON inside Houdini. With #4700 OCIO is correctly passed to Houdini, but setting OCIO profiles (and other options) on relevant nodes needs to be done manually. Like these options in OpenGL ROP (introduced by #3839):

image

This is somehow similar to #4833.

There might be other places to set.

How would you imagine the implementation of the feature?

It should be done as it is already done in Nuke, where you can set color spaces like this:

image

Are there any labels you wish to add?

  • I have added the relevant labels to the enhancement request.

Describe alternatives you've considered:

No response

Additional context:

No response

[cuID:OP-5602]

@antirotor antirotor added type: enhancement Enhancements to existing functionality host: Houdini labels Apr 12, 2023
@BigRoy
Copy link
Collaborator

BigRoy commented Apr 20, 2023

What would be a decent default colorspace to set for the review output files. What setting should we obey to?
Would it the preferred rendering space? or the display space? (Houdini doesn't have any settings for that however).
In the case of Nuke. I'm still not sure what the color space should be set to for this case.

@MustafaJafar
Copy link
Contributor

MustafaJafar commented Jul 17, 2023

I was reviewing this issue #4833
and I believe it depends on this issue.

As far as I know, Houdini requires setting OCIO profiles (and other options) manually as Houdini nodes don't inherit color management settings like in Maya.

I can think of two solutions

  1. Set color space dynamically so that a plugin will deduce what color space to use from default display and default view
  2. Expose Parameters to Ayon/OpenPype Settings UI so that a plugin will use these exposed parameters

For the mentioned example OpenGL, This solution worked for me.
I used the same OCIO Color correction as hou.Color.ocio_defaultView() which is almost the same that happens with Maya playblast (to use view transform)

image

There's also another problem in houdini that not all nodes have explicit colorspace parameters, and they will use scene_linear implicitly (e.g. mantra, texture read).
so, I think there will be some tweaking in all ROPs.

what do you think ?
@BigRoy @antirotor @moonyuet

@antirotor
Copy link
Member Author

I am not sure if we should touch explicit set colorspaces. My guess is that productions usually assume that colorspaces that are explicitly set remains so, but I don't know. Maybe we should implement is when requested and it could be done as in Nuke perhaps? Otherwise the way with ocio_defaultView() seems reasonable for me.

@BigRoy
Copy link
Collaborator

BigRoy commented Jul 4, 2024

This overlaps a lot with #67

@MustafaJafar still relevant?

@MustafaJafar
Copy link
Contributor

This overlaps a lot with #67
yes, they are, as far as I know.

The associated internal ticket was closed by ondrej so it's fair to close this one.

For reference, it's related to
#5322
ynput/ayon-core#36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host: Houdini type: enhancement Enhancements to existing functionality
Projects
None yet
Development

No branches or pull requests

3 participants