Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Illogical schema change in file download #7

Open
iLLiCiTiT opened this issue Jul 3, 2023 · 0 comments
Open

Illogical schema change in file download #7

iLLiCiTiT opened this issue Jul 3, 2023 · 0 comments

Comments

@iLLiCiTiT
Copy link
Member

Description

There is a change of protocol from https to http in download file https://github.com/ynput/ayon-launcher/blob/main/common/ayon_common/distribution/file_handler.py#L116 which does not make much sense. If the url would be invalid it would crash in _get_redirect_url method because of urllib.error.HTTPError.

Don't remember why that part was added, maybe should be removed and added back when we find out why it is like that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iLLiCiTiT