Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigate to previous or next short without animation with W and S doesn't work #142

Open
bojacc opened this issue Oct 6, 2023 · 10 comments
Labels
good first issue Good for newcomers question Further information is requested (such as feasibility)

Comments

@bojacc
Copy link

bojacc commented Oct 6, 2023

Hi, in version 3.0.1, the shorts are not getting navigated without animation, the shortcut doesn't work out of the box however if we do set up a Keybind for next/previous shorts, it gets navigated with the default animation.
I tried with Edge browser (Version 117.0.2045.5) and Firefox browser (118.0.1).
Not sure if it is just me or other people are facing it as well, although not a dealbreaker though.

I installed a previous version of extension on firefox browser, all other features were broken however the W/S without animation switching was working flawlessly.

@adsuth
Copy link
Collaborator

adsuth commented Oct 6, 2023

which version specifically had it without the animation? I know that we changed the way it skips a short to synthetically click the next button instead of instantly scrolling down because we were seeing issues on mac with the latter

@ynshung
Copy link
Owner

ynshung commented Oct 6, 2023

It seems like clicking the previous/next button now also triggers the animation and it's probably a change from youtube themselves. If there isn't any way to skip shorts without animation, we'll either leave the keybinds and remove the part we mention about skipping without animation or remove it altogether

@ynshung ynshung added the question Further information is requested (such as feasibility) label Oct 6, 2023
@bojacc
Copy link
Author

bojacc commented Oct 6, 2023

It seems like clicking the previous/next button now also triggers the animation and it's probably a change from youtube themselves. If there isn't any way to skip shorts without animation, we'll either leave the keybinds and remove the part we mention about skipping without animation or remove it altogether

Yes it could be, but i just posted this to confirm with others if others were also experiencing this issue.
It was actually pretty snappy that non-animation switching to next/previous reel, i liked it haha.

@bojacc bojacc closed this as completed Oct 6, 2023
@bojacc
Copy link
Author

bojacc commented Oct 6, 2023

which version specifically had it without the animation? I know that we changed the way it skips a short to synthetically click the next button instead of instantly scrolling down because we were seeing issues on mac with the latter

2.7.2

@bojacc bojacc reopened this Oct 6, 2023
@adsuth
Copy link
Collaborator

adsuth commented Oct 8, 2023

Gave it a check, and 2.7.2 was still doing the old method of moving between shorts.

Could potentially add a "no animation" option that uses that old method, but again, that may not work on other devices

@bojacc
Copy link
Author

bojacc commented Oct 11, 2023

Gave it a check, and 2.7.2 was still doing the old method of moving between shorts.

Could potentially add a "no animation" option that uses that old method, but again, that may not work on other devices

Thank you for the prompt response. I would really appreciate if it can be implemented, however if there are a lot of variables involved, i dont mind the short switching animation much. Thank you for all the work done on this extension. x)

@bojacc
Copy link
Author

bojacc commented Oct 15, 2023

Hi,
just wanna follow up with an something I observed.

I recently found this extension in microsoft edge extensions store and the current version is v2.8.3
And the W/S navigation is working here without the animation and I superlike it. Autoplay and most of other features are not available but I guess for now I can live with it.
So here's a request, could you please link me to the unpacked version of v2.8.3 so that this extension doesn't auto-update and it disables that feature of no animation navigation?

@ynshung
Copy link
Owner

ynshung commented Oct 15, 2023

Hi there @bojacc, you could navigate to the v2 branch here and download the repository as ZIP then load them unpacked from there

@bojacc
Copy link
Author

bojacc commented Oct 15, 2023

Thank you. Appreciate the help.

Any plans on keeping this feature alive in v3?

@ynshung
Copy link
Owner

ynshung commented Oct 16, 2023

Definitely will try to search a workaround for this. It would be great if anyone could find the solution for this

@ynshung ynshung added the good first issue Good for newcomers label Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers question Further information is requested (such as feasibility)
Projects
None yet
Development

No branches or pull requests

3 participants