Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(zone): handle offset when parent is flex #182

Merged
merged 2 commits into from
Mar 26, 2022
Merged

fix(zone): handle offset when parent is flex #182

merged 2 commits into from
Mar 26, 2022

Conversation

yoannmoinet
Copy link
Owner

Fixes #181

When the parent is display: flex somehow the offset is wrong.
I suspect that the context of the getBoundingBox is inexistant in flex mode.

The solution would be to remove that offset when we detect that the parent is display: flex.

@yoannmoinet yoannmoinet mentioned this pull request Mar 18, 2022
Closed
@yoannmoinet yoannmoinet changed the title Fix offset when parent is flex. fix(zone): handle offset when parent is flex Mar 26, 2022
@yoannmoinet yoannmoinet merged commit 037ee58 into master Mar 26, 2022
@yoannmoinet yoannmoinet deleted the yoann/fix-flex-offset branch March 26, 2022 09:53
yoannmoinet added a commit that referenced this pull request Mar 26, 2022
@yoannmoinet
fix(zone): handle offset when parent is flex (#182)
ef9ec5a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Joystick not appearing in correct location when used in the svelte framework
1 participant
@yoannmoinet