Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create html/css mock for code-is-science "add a journal page". #13

Closed
yochannah opened this issue Oct 18, 2017 · 10 comments
Closed

create html/css mock for code-is-science "add a journal page". #13

yochannah opened this issue Oct 18, 2017 · 10 comments
Labels
code-task This task will involve writing code of some sort - but it's okay to pick up and ask for help too! design task Want to contribute to open source with your nifty design skills? Pick up this issue! first-timers-only New to open source? Pick up this task & we'll help with any questions <3 good first issue Great for new-to-open source folk. We'll help you, step-by-step Hacktoberfest If it's October and you want to contribute to open source, this issue is for you! help wanted Input from others appreciated but not necessarily as easy at first-timers-only or good first issue

Comments

@yochannah
Copy link
Collaborator

This issue follows on from #12 and should only be completed after #12 is complete. Use the same design principles and the same header/footer from the previous mock.

Mock 2 - add a journal

Add a journal page

  • header and footer same as homepage
  • no sidebar
  • main body:
    • form with following text fields
      • journal name
      • journal link
      • discipline (use can type more than one, comma separated)
    • checkbox fields:
      • no
      • unclear / unknown
      • reviewers see source, but code doesn't have to be published openly
      • artifact deposited
      • yes, must have osi-approved licence.
    • submit button.

form submission functionality will be added later and is not required for this task.
@yochannah yochannah added code-task This task will involve writing code of some sort - but it's okay to pick up and ask for help too! design task Want to contribute to open source with your nifty design skills? Pick up this issue! Hacktoberfest If it's October and you want to contribute to open source, this issue is for you! help wanted Input from others appreciated but not necessarily as easy at first-timers-only or good first issue labels Oct 18, 2017
@yochannah yochannah mentioned this issue Oct 18, 2017
Closed
@yochannah yochannah changed the title create html/css mock for code-is-science adda journal page. create html/css mock for code-is-science "add a journal page". Oct 18, 2017
@HeidiSeibold
Copy link

Have you already started the list somewhere? You could already get it started with e.g. an open google sheet?

@yochannah
Copy link
Collaborator Author

Hey @HeidiSeibold! I do have a submission form; it's sadly lacking in responses right now though :( Feel free to add some if you know of any offhand.

Form: https://goo.gl/forms/ScgFcKJrfIUTBOl83
Responses: https://docs.google.com/spreadsheets/d/1oY5ak7VJa-qwJJeWA3829S-1akZaYtHuWPYpChBdW2o/edit#gid=0

@HeidiSeibold
Copy link

I submitted two :)

Let me know if you need help promoting the list (e.g. on twitter)

@yochannah yochannah added good first issue Great for new-to-open source folk. We'll help you, step-by-step first-timers-only New to open source? Pick up this task & we'll help with any questions <3 labels Mar 24, 2018
@yochannah
Copy link
Collaborator Author

yochannah commented Mar 24, 2018 •
edited

I've added first timers only tags to this issue, as #12 is now complete.

Newcomers: If you'd like to pick up this issue, here's what to do!

  1. Please look at the code from this PR: Finished web mock-up #22
  2. Comment on this issue and let me know you're working on it! <3
  3. Fork this repo and make a copy of static/index.html, then rename it something sensible like add-a-journal.html or similar.
  4. Modify your new page copy so it looks like the hand-drawn mockup above!
  5. When you're ready, make a PR (guidance here if needed: https://help.github.com/articles/creating-a-pull-request/ )
  6. Bask in your awesomeness!

If you need help:

Mention me, @yochannah, tweet me @yoyehudi, or email yochannah@gmail.com.

@ikayz
Copy link
Collaborator

ikayz commented Mar 24, 2018

@yochannah I have decided to work on this one as well.

@yochannah
Copy link
Collaborator Author

Sure, go ahead! :)

@ikayz
Copy link
Collaborator

ikayz commented Mar 26, 2018

@yochannah finished working on it. Check PR.

@yochannah
Copy link
Collaborator Author

yochannah commented Mar 27, 2018 via email

@ikayz
Copy link
Collaborator

ikayz commented Mar 27, 2018

Alright

@yochannah
Copy link
Collaborator Author

fixed by #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code-task This task will involve writing code of some sort - but it's okay to pick up and ask for help too! design task Want to contribute to open source with your nifty design skills? Pick up this issue! first-timers-only New to open source? Pick up this task & we'll help with any questions <3 good first issue Great for new-to-open source folk. We'll help you, step-by-step Hacktoberfest If it's October and you want to contribute to open source, this issue is for you! help wanted Input from others appreciated but not necessarily as easy at first-timers-only or good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yochannah @HeidiSeibold @ikayz