Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pendo api key / section issue #84

Closed
BruneXX opened this issue Sep 11, 2023 · 8 comments
Closed

Pendo api key / section issue #84

BruneXX opened this issue Sep 11, 2023 · 8 comments
Labels
help wanted Extra attention is needed

Comments

@BruneXX
Copy link

BruneXX commented Sep 11, 2023

Error: node_modules/ngx-pendo/lib/ngx-pendo-id.directive.d.ts:18:90 - error TS2344: Type '{ pendoId: { alias: "ngx-pendo-id"; required: false; }; inherit: { alias: "ngx-pendo-inherit"; required: false; }; }' does not satisfy the constraint '{ [key: string]: string; }'.
Property '"pendoId"' is incompatible with index signature.
Type '{ alias: "ngx-pendo-id"; required: false; }' is not assignable to type 'string'.

18 static ɵdir: i0.ɵɵDirectiveDeclaration<NgxPendoIdDirective, "[ngx-pendo-id]", never, { "pendoId": { "alias": "ngx-pendo-id"; "required": false; }; "inherit": { "alias": "ngx-pendo-inherit"; "required": false; }; }, {}, never, never, false, never>;

Error: node_modules/ngx-pendo/lib/ngx-pendo-section.directive.d.ts:18:100 - error TS2344: Type '{ pendoSection: { alias: "ngx-pendo-section"; required: false; }; inherit: { alias: "ngx-pendo-inherit"; required: false; }; }' does not satisfy the constraint '{ [key: string]: string; }'.
Property '"pendoSection"' is incompatible with index signature.
Type '{ alias: "ngx-pendo-section"; required: false; }' is not assignable to type 'string'.

18 static ɵdir: i0.ɵɵDirectiveDeclaration<NgxPendoSectionDirective, "[ngx-pendo-section]", never, { "pendoSection": { "alias": "ngx-pendo-section"; "required": false; }; "inherit": { "alias": "ngx-pendo-inherit"; "required": false; }; }, {}, ["idDirectives", "sectionDirectives", "allIdDirectives"], never, false, never>;

@BruneXX
Copy link
Author

BruneXX commented Sep 11, 2023

Well the issue is that the directive files

  • ngx-pendo-id.directive.d.ts
  • ngx-pendo-section.directive.d.ts

The following lines should looks like these:

static ɵdir: i0.ɵɵDirectiveDeclaration<NgxPendoIdDirective, "[ngx-pendo-id]", never, {
  "pendoId": "ngx-pendo-id"; // Specify that pendoId is a string
  "inherit": "ngx-pendo-inherit"; // Specify that inherit is a string
}, {}, never, never, false, never>;

Note: that was my finding at those compiled files, so we should look at these files to find the issue and fix it:

@damingerdai
Copy link
Collaborator

what is your angular version

@BruneXX
Copy link
Author

BruneXX commented Sep 12, 2023

Hi @damingerdai it's 15.2.9

@BruneXX
Copy link
Author

BruneXX commented Sep 13, 2023

Hi @damingerdai Do you have any update on this? thanks!

@damingerdai damingerdai added the help wanted Extra attention is needed label Sep 13, 2023
@damingerdai
Copy link
Collaborator

Can you provide a minimal demo?

@damingerdai
Copy link
Collaborator

i test on my local pc with angular 15.2.9 and ngx-pendo 1.11.0. it look like work for me

@BruneXX
Copy link
Author

BruneXX commented Sep 14, 2023

Hi @damingerdai I think then the issue is that I'm using the ngx-pendo v1.12.0
I'm reviewing that right now, but if that's the case, can you please add a table to match/map the Angular version and ngx-pendo version to use? Thanks!

@BruneXX
Copy link
Author

BruneXX commented Sep 14, 2023

@damingerdai confirmed, in angular v15.2.9 with ngx-pendo > v1.11.0 works fine, I think ngx-pendo v1.12.0 will be just for newer versions. it will be awesome if we could have a mapping table. Thanks!

@BruneXX BruneXX closed this as completed Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants