Unable to Stop "In Progress" and Pending Scans

[quantumburnz]

Hi,
I saw a previously closed issue, #298 , but I'm still experiencing this. The first scan stuck "In Progress" was because my host shut-down mid-scan. The two Pending scans are due to an issue I haven't figured out yet.

[github-actions]

👋 Hi @quantumburnz,
Issues is only for reporting a bug/feature request. Please read documentation before raising an issue https://rengine.wiki
For very limited support, questions, and discussions, please join reNgine Discord channel: https://discord.gg/azv6fzhNCE
Please include all the requested and relevant information when opening a bug report. Improper reports will be closed without any response.

[quantumburnz]

I was able to delete these two Pending scans. Therefore, perhaps if a scan is in this state, the UI could say they can't be stopped but they can be deleted instead of the generic "Oops!" message currently displayed.

Later edit with additional info: It seems more nuanced than this. I had targets in a Pending state as part of an Organization scan, and I was able to stop these. Either way, hopefully the true state can be differentiated and feedback provided to the user appropriately.

[nednones]

@quantumburnz Can you explain how you managed to stop the scan, e.g. did you kill the process inside the container or did it happen from when you hit stop on the UI?

[quantumburnz]

Hi @nednones - I did not kill any processes. I've observed a few different scan states and the actions I could take depended upon the scenario. This leads me to believe we probably need a feature request for better state tracking. I think I was only able to successfully stop a scan in scenario 2 below.

1. Scan is stuck in "In Progress" but it actually isn't doing anything, it's just a "dead" scan so there's actually nothing to stop
2. Scan is "Pending" meaning it hasn't technically started yet but you can stop it (and maybe even delete it?)
3. Scan is "In Progress" and actually scanning, and you should (might?) be able to actually stop it

If I really had to stop a scan, and I couldn't do it via the UI, I'd confirm the scan was running by look at 'sudo make logs' and then probably 'sudo make stop' or 'sudo make down' to stop and/or delete the containers and start fresh (taking a DB back-up first before down'ing if I wanted one). Hopefully this is a little helpful.

[yogeshojha]

There was an issue on api to stop scans, which has now been fixed in 1.2.0