Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Meteor 1.2? #277

Closed
ndarilek opened this issue Sep 23, 2015 · 16 comments
Closed

Compatibility with Meteor 1.2? #277

ndarilek opened this issue Sep 23, 2015 · 16 comments

Comments

@ndarilek
Copy link

Looks like various dependencies make it impossible to run this on Meteor 1.2. In particular, less and at least one additional package appear to require upgrades.

Any plans to make this run under 1.2? I can't upgrade any projects using this package because of its dependency constraints.

Thanks.

@TimoRuetten
Copy link

+1

2 similar comments
@pozylon
Copy link

pozylon commented Sep 23, 2015

+1

@ghost
Copy link

ghost commented Sep 23, 2015

+1

@znat
Copy link

znat commented Sep 23, 2015

+2

@CaptainN
Copy link
Contributor

I have a pull request up for this. #276

For now you can download either a fork, or just a unzip an archive of this repo (or mine) and place it in your packages folder. Then make sure the LESS reference is updated to include the new required version number: less@1.0.0 || 2.5.0. Update: I changed the less dep so that it works for old versions of meteor too.

@derdaumen
Copy link

+1

@macrozone
Copy link

it is now merged and seems to work with meteor 1.2. Close?

@CaptainN
Copy link
Contributor

There is actually a second issue. The less patch gets the package to install, but the data tables in the collection list pages are not working correctly in meteor 1.2 if the collection has any records.

@thomasspiesser
Copy link

is it the same as #280 ? can anyone still use this package with 1.2?

@CaptainN
Copy link
Contributor

The issue I mentioned above about the data tables is the same as #280. The same issue was fixed in flow-db-admin - maybe someone could figure out what fixed it there, and apply the same fix here?

@cagrigunal
Copy link

+1

1 similar comment
@MartinBucko
Copy link

+1

@CaptainN
Copy link
Contributor

CaptainN commented Oct 5, 2015

Please clone my repo to your local packages directory and see if my fix for the collection views works for you: https://github.com/CaptainN/meteor-admin/

@Maay
Copy link

Maay commented Oct 7, 2015

@CaptainN thank you!

@CaptainN
Copy link
Contributor

CaptainN commented Oct 9, 2015

I redid my fork (because I screwed it up - still new to fork and PR workflow). The new PR #289 has the same fix and also a fix for the Users table.

@CaptainN
Copy link
Contributor

CaptainN commented Oct 9, 2015

Oh, it looks like my original PR #284 has the fix too. I think I'm starting to understand how the PR system works. :-)

@snamoah snamoah closed this as completed Dec 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests