Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trivy scanner CI integration support #166

Closed
yoheimuta opened this issue Jun 6, 2021 · 4 comments · Fixed by #188
Closed

trivy scanner CI integration support #166

yoheimuta opened this issue Jun 6, 2021 · 4 comments · Fixed by #188
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@yoheimuta
Copy link
Owner

ref. #163 (comment)

@wwuck
Copy link
Contributor

wwuck commented Nov 3, 2021

I am looking at this, but would you have any interest in migrating from circleci to github actions? Or would you prefer it be implemented on the existing circleci configuration?

I have no direct experience with either so I thought it would be a good opportunity for me to learn github actions. I am happy either way whatever you choose.

https://docs.github.com/en/actions/migrating-to-github-actions/migrating-from-circleci-to-github-actions

@wwuck
Copy link
Contributor

wwuck commented Nov 3, 2021

https://blog.aquasec.com/devsecops-with-trivy-github-actions
https://github.com/aquasecurity/trivy-action

or perhaps even better, would be this action?
https://github.com/marketplace/actions/container-image-scan
from Microsoft Azure, which runs both Trivy and Dockle.

I would also look at adding hadolint action
https://github.com/marketplace/actions/hadolint-action

@yoheimuta
Copy link
Owner Author

would you have any interest in migrating from circleci to github actions?
Or would you prefer it be implemented on the existing circleci configuration?

@wwuck Thank you for your interest!
I'm happy to help you.

Yes, I prefer migrating to GitHub Action.

However, if this migration seems overwhelmed for you, considering your experience, would it be better to add GitHub Action for this trivy scan? In precise, we don't need to consolidate CI this time as the first step. Instead, you can focus on adding this feature alone. Either approach is fine for me 😸

@wwuck
Copy link
Contributor

wwuck commented Nov 3, 2021

Thanks! I will take a look at GitHub Actions and see how I go with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants