Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question regarding cryptojacking toggle #31

Closed
devipasigner opened this issue Mar 26, 2023 · 5 comments · Fixed by #34
Closed

Question regarding cryptojacking toggle #31

devipasigner opened this issue Mar 26, 2023 · 5 comments · Fixed by #34
Assignees
Labels

Comments

@devipasigner
Copy link

All recommended lists (and alternate) include the cryptojacking list in NextDNS's built in cryptojacking protection. (with additional false positives removed).

So my question is why advise people to enable it? One of the lists are not maintained often and hagezi has stripped some false positives out of it.

@yokoffing
Copy link
Owner

yokoffing commented Apr 3, 2023

Just thinking out loud: NextDNS internalized many of their lists, which weakened the case for this. They probably still use those one or two lists, but we cannot confirm that.

If we assume they use the same two lists:

  • We could view this as a defense-in-depth and keep it enabled.
  • We could encounter false positives that NextDNS does not allowlist but other maintainers do, and recommend users disable Cryptojacking Protection (your point).

Questions: Should we leave it enabled in case someone doesn't use the recommended privacy blocklists? What about the user who utilizes different lists?

cc: @hagezi @iam-py-test @DandelionSprout thoughts?

@yokoffing yokoffing added the 💬 discussion Discussion label Apr 3, 2023
@hagezi
Copy link

hagezi commented Apr 3, 2023

I have activated it and have had no problems so far. Unfortunately, you can not see what is behind this function, because the lists are internal and not public. Maybe @romaincointepas or @rs can give information about this?

@SpidaXS
Copy link

SpidaXS commented Apr 11, 2023

I have activated it and have had no problems so far. Unfortunately, you can not see what is behind this function, because the lists are internal and not public. Maybe @romaincointepas or @rs can give information about this?

I don't recommend you enable this, there are many more false positive

@norilana
Copy link

image

@iam-py-test
Copy link
Contributor

This is a known issue with the NoCoin filterlist (which I guess they are using?): hoshsadiq/adblock-nocoin-list#452

@yokoffing yokoffing linked a pull request May 2, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants