Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Log instead of Logs #6

Merged
merged 1 commit into from May 21, 2022
Merged

Use Log instead of Logs #6

merged 1 commit into from May 21, 2022

Conversation

palainp
Copy link
Contributor

@palainp palainp commented May 18, 2022

I don't know if this was intentional but the logs print currently doesn't seems to be homogeneous, using Logs:

Logs.err (fun m -> m "error reading block pair %Ld, %Ld (0x%Lx, 0x%Lx): %a"

will print a line with label [application] while with Log:
Log.err (fun f -> f "error reading block %Ld : %s"

the label will be clearer ([chamelon-fs] or equivalent for other .ml).

This PR changes Logs into Log to have each line associated with the correct log label.

@yomimono
Copy link
Owner

It absolutely wasn't intentional! I appreciate the fix.

@yomimono yomimono merged commit 33dff03 into yomimono:main May 21, 2022
@palainp palainp deleted the fix-logs branch May 21, 2022 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants