Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss: passing clientset to functions instead of kubeconfig #68

Closed
Yuni-sa opened this issue Sep 10, 2023 · 3 comments · Fixed by #81
Closed

Discuss: passing clientset to functions instead of kubeconfig #68

Yuni-sa opened this issue Sep 10, 2023 · 3 comments · Fixed by #81

Comments

@Yuni-sa
Copy link
Contributor

Yuni-sa commented Sep 10, 2023

I was thinking of creating a project using kor as a go library, the goal is an agent running inside the kubernetes cluster and periodically logging unused resources and exporting metrics, for this to be possible the conventional method is to create a clientset using the service account that the pod uses.
(rest.InClusterConfig() uses the mounted SA inside the pod)

currently kor passes kubeconfig to the functions instead of the clientset (that could be created from an SA) so you can't use the kor library without a kubeconfig inside of the pod.

@yonahd
Copy link
Owner

yonahd commented Sep 10, 2023

Hey @Yuni-sa
This is exactly the direction I'm pulling the project. The first step is #64

@yonahd
Copy link
Owner

yonahd commented Sep 10, 2023

In the background we can start putting in the pieces for when kor is running in-cluster

You're welcome to the discussion here #69

@yonahd
Copy link
Owner

yonahd commented Sep 13, 2023

@Yuni-sa Would you be open to making this change as a prerequisite to #77

@yonahd yonahd linked a pull request Sep 14, 2023 that will close this issue
@yonahd yonahd closed this as completed Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants