Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relative Paths for Included Settings, Legacy workingDirectory #979

Closed
jcolicchio opened this issue Nov 2, 2020 · 2 comments · Fixed by #981
Closed

Relative Paths for Included Settings, Legacy workingDirectory #979

jcolicchio opened this issue Nov 2, 2020 · 2 comments · Fixed by #981

Comments

@jcolicchio
Copy link
Contributor

I've got a yaml file that I want to include from different directories, but I ran into a couple of issues with some paths not adjusting relative to the including directory

  1. LegacyTarget's workingDirectory
  2. settings's HEADER_SEARCH_PATHS

I think it'd be nice if these paths adjusted according to the directory of the yaml file they're being included into
@jcolicchio
Copy link
Contributor Author

I'll draft a PR that makes these changes tonight or tomorrow

@jcolicchio jcolicchio mentioned this issue Nov 2, 2020
Merged
@jcolicchio
Copy link
Contributor Author

We'll leave HEADER_SEARCH_PATHS be for now, but the workingDirectory will be made relative to the including project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Legacy / Settings Relative Paths jcolicchio/XcodeGen
1 participant
@jcolicchio