Ability to set selected segment's label's text color

[StainlessStlRat]

When the segment is selected, it sets the label color to .background.

This is fine for the default colors, but my tint is a shade of blue. I'd prefer that when the segment is selected, the text color is white, but in night mode the text will be black.

[yonat]

I made two changes that should help:

1. use the real background color of the view behind instead of the system background.
2. implement setTitleTextAttributes(_:for:) (works like its UISegmentedControl counterpart).

Hope it works for you!

[StainlessStlRat]

Perfect! Thanks for being so responsive!

[StainlessStlRat]

Not sure what I'm doing wrong here, but I get an unrecognized selector error in obj C (even though the function autofills). _ownedComponents is the multiselectedsegmentedcontrol:

NSDictionary *attributes = @{NSForegroundColorAttributeName : [UIColor whiteColor]};
[_ownedComponents setTitleTextAttributes:attributes for:UIControlStateSelected];

[StainlessStlRat]

So I was thinking that you have the two colors: tint and background. Shouldn't they just be switched when the item is selected?

Ex: My tint is blue-ish, my background is white.
Unselected == white background / blue text
Selected == blue background / white text

Is that what you meant for #1? If so, that #1 behavior is not working on my end.

[yonat]

About the undefined selector:
I think the objc counterpart is setTitleTextAttributes:forState (instead of the for: in Swift) - like in https://developer.apple.com/documentation/uikit/uisegmentedcontrol/1618570-settitletextattributes?language=objc .

[StainlessStlRat]

It won't compile if I set it to that. Says "no recognized selector"

[yonat]

About the background color behavior:
What do you see when you select a segment?
Would you upload a picture? (with some background around the control for comparison)

[yonat]

Do you get auto completion for the objc?

[StainlessStlRat]

Yes it autocompleted weirdly enough!

[StainlessStlRat]

[StainlessStlRat]

I want the same colors whether or not it's night mode if that matters

[StainlessStlRat]

Also anyway to make the divider thinner? Feels like it's thicker than it used to be

[yonat]

Where does the white comes from? The unselected background is clear.
If you make the white view into the superview of the control, it should work.

[StainlessStlRat]

I've got it set to white in interface builder. If I set it to clear won't the background be dark? That'll clash with the blue color/make it hard to read

[yonat]

dividers are the same width as border, so:

multi.borderWidth = 0.5

[StainlessStlRat]

Ah I looked in the code and could swear it was set to 1.0

[yonat]

Hmmm. didn't thing to use the control's own backgroundColor. That's a good idea actually.

[StainlessStlRat]

@IBInspectable open dynamic var borderWidth: CGFloat = 1 {

Does this mean it's set to 1.0?

[yonat]

Yes.

[StainlessStlRat]

Ohhh gotcha

[StainlessStlRat]

Small defects if I set it lower. Look at the left hand side. You can see white around the border

[yonat]

Fixing the background color thing, will push in a few minutes.

[StainlessStlRat]

Awesome! Thanks for being so responsive!

[yonat]

You caught me in a good time!
Just pushed 2.1.1 with the fixes. Now your code should just work, without setting foreground color.

[StainlessStlRat]

Hm still getting the same behavior

[StainlessStlRat]

Did you fix the sliver showing on the left? I still see that too. Maybe I messed something up

[yonat]

Weird. Sure you updated the pod/package? Maybe do a Product>Clean and then try again.

[StainlessStlRat]

Clean rebuild fixed it!

[StainlessStlRat]

[StainlessStlRat]

There's still an ever so small sliver of white on the leftmost segment if it's selected. Any idea what that is? I'm just worried that on other devices it might be even more pronounced!

[yonat]

Probably antialiasing. Doesn't reproduce for me, maybe try to ensure the view is aligned to whole pixels and see if it changes anything.

[StainlessStlRat]

Ya it's definitely whole pixels. I didn't even realize you could set constraints that were sub pixel. Happens on another view where I use the tool that just uses autoresizemasks too

[StainlessStlRat]

When you test for the sliver of white on the side, have you set the border width to 0.5? It only happens when I try to make the border sizes look more like they used to by setting them to 0.5

[yonat]

Half pixel can happen unintentionally, as a result of centering or indenting.
Anyway, it doesn't reproduce for me so I can't fix it. If you send me a project that reproduce this behavior (and specify on which simulator to run it) then I can try to fix it.