Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crs as argument #19

Closed
KevCaz opened this issue Sep 25, 2020 · 1 comment
Closed

crs as argument #19

KevCaz opened this issue Sep 25, 2020 · 1 comment

Comments

@KevCaz
Copy link
Contributor

KevCaz commented Sep 25, 2020

IMHO, the user should be able to change the CRS when needed. So far, esri2sfGeom() does not allow the user to do so.

I introduced this argument in my branch (https://github.com/inSileco/esri2sf) and fix some other issues (including #18) to have a clean build (meaning no warnings and no errors on devtools::check()), I can create a PR if you are interested.
@yonghah
Copy link
Owner

yonghah commented Oct 8, 2020

Great! It would be really awesome if you create a PR for this repo!

@KevCaz KevCaz mentioned this issue Oct 9, 2020
Merged
@yonghah yonghah closed this as completed Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KevCaz @yonghah