Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin dependencies #64

Closed
frankier opened this issue Jul 29, 2018 · 2 comments
Closed

Unpin dependencies #64

frankier opened this issue Jul 29, 2018 · 2 comments

Comments

@frankier
Copy link

Currently the setup.py includes a requirements.txt, which requires specific versions of every requirement. This causes problems when combined with other software since they could require a version range which isn't compatible with the specific version required here.

Or consider another scenario: I need a newer version of e.g. requests, then I'm stuck because this package is pinned to an older version.

This article goes into a bit more depth about why setup.py should be treated differently to requirements.txt https://caremad.io/posts/2013/07/setup-vs-requirement/

My suggestion is that the dependencies should be moved into setup.py and the version should be changed to minimum versions (using >=) rather than exact version requirements.

@korenyoni
Copy link
Owner

Given those scenarios I think that's a great suggestion. I will read that article.

Feel free to make a PR if you get the time. Otherwise I'll try to do this when I get the chance -- probably not immediately. I will comment here if I do begin work on another branch.

@korenyoni
Copy link
Owner

This is closed with #66. Issue #69 is going to be solved with unpinned dependencies. Thanks @frankier, for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants