Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

End to end example #5

Closed
nivha opened this issue Jan 23, 2020 · 5 comments
Closed

End to end example #5

nivha opened this issue Jan 23, 2020 · 5 comments

Comments

@nivha
Copy link
Contributor

nivha commented Jan 23, 2020 •
edited

Great project! Adding an end to end example would be very helpful.
(for example, the mnist example, but adding how the data was created and so on)

(also, there are hard-coded paths in the code, such as in modules.py line 165)
@YontiLevin
Copy link
Owner

Thanks!

It might take me a while as Im a bit busy lately.
I will keep this issue open to remind me.

@nivha nivha closed this as completed Jan 26, 2020
@nivha
Copy link
Contributor Author

nivha commented Jan 26, 2020 •
edited

accidentally closed..

@nivha nivha reopened this Jan 26, 2020
@YontiLevin
Copy link
Owner

if you already improved the code then please open a pull request
lets try to push that in for others

@nivha
Copy link
Contributor Author

nivha commented Jan 26, 2020

there you go, added here #6

@YontiLevin
Copy link
Owner

thanks
PR was approved and merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nivha @YontiLevin