Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

generateChunksFiles should not affect generateChunksManifest #53

Closed
bseib opened this issue Mar 30, 2020 · 1 comment 路 Fixed by #54
Closed

generateChunksFiles should not affect generateChunksManifest #53

bseib opened this issue Mar 30, 2020 · 1 comment 路 Fixed by #54
Labels
bug Something isn't working

Comments

@bseib
Copy link
Contributor

bseib commented Mar 30, 2020

馃悰 Bug Report

When generateChunksFiles is false and generateChunksManifest is true, it generates a chunks-manifest.json file and zero html files as expected. However, the content of the chunks-manifest.json file is an empty JSON object: {}.

Steps to reproduce

    // webpack.config.js
    plugins: [
      // ...
      new ChunksWebpackPlugin({
        generateChunksManifest: true,
        generateChunksFiles: false
      }),
    ]

Results

content of chunks-manifest.json looks like:

{}

Expected

{
  "name1": {
    "styles": [],
    "scripts": [
      "name1-98d2dfd5d8639d97c965.js"
    ]
  },
  "name2": {
    "styles": [],
    "scripts": [
      "vendors~name2-425439141846a1f81cd7.js",
      "name2-5774606e763f84c98d93.js"
    ]
  }
}

ChunksWebpackPlugin

What version of ChunksWebpackPlugin does this occur with?

"chunks-webpack-plugin": "4.0.2",

@bseib bseib added the bug Something isn't working label Mar 30, 2020
@yoriiis
Copy link
Owner

yoriiis commented Mar 31, 2020

Hello @bseib, thanks for the report and the PR 馃憤

This has been merged in master.
Release 4.0.3 is available ! 馃帀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants