Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the deployment script of JS SDK by following TypeScript's publishing guide #95

Closed
hackerwins opened this issue Oct 3, 2020 · 0 comments · Fixed by #97
Closed
Assignees
Projects

Comments

@hackerwins
Copy link
Member

When I import Yorkie JS SDK from CodePair created with create-react-app with TypeScript enabled, I confirmed that it does not work properly.

./node_modules/yorkie-js-sdk/src/yorkie.ts 24:33
Module parse failed: Unexpected token (24:33)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
| //  e.g) yorkie.createClient(...)
| export default {
>   createClient: function (rpcAddr: string, opts?: ClientOptions): Client {
|     return new Client(rpcAddr, opts);
|   },

We need to modify the deployment script of JS SDK by following TypeScript's publishing guide.

@dc7303 dc7303 mentioned this issue Oct 3, 2020
2 tasks
@hackerwins hackerwins self-assigned this Oct 10, 2020
@hackerwins hackerwins added this to Done in v0.1 Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
v0.1
Done
1 participant