Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time issue #8

Closed
kvpt opened this issue Jan 24, 2018 · 2 comments
Closed

Time issue #8

kvpt opened this issue Jan 24, 2018 · 2 comments
Labels

Comments

@kvpt
Copy link
Contributor

kvpt commented Jan 24, 2018

Hi,

I use this library in an application (Xamarin) deployed on mobile devices, which may have network connection reliability issues.

It works great 99.99%, but sometime in my api, I receive call from the app with invalid dates.
For example :

  • 01/01/1900 01:05:12
  • 01/01/1900 01:04:55
  • 01/01/1900 00:32:17

I found in the code here that the default time is 01/01/1900, so I suspect an incomplete buffer to cause this issue.

My question is how to handle this case ?

A/ An exception must be raised by the library
B/ Date must be verified by user code

@Yortw
Copy link
Owner

Yortw commented Jan 24, 2018

Hi,

Thanks for the bug report. I believe the correct behaviour is for the library to throw an exception or raise the exception event, and not raise the time event providing an incorrect time in the scenario described. Unfortunately this is not something I've experienced myself, so I will need to find time to reproduce and/or study the code to find a way to detect the problem and handle it appropriately.

Thanks again.

@Yortw Yortw added the bug label Jan 24, 2018
@Yortw
Copy link
Owner

Yortw commented Feb 2, 2018

Hi,

I've just pushed an update that I hope fixes this. Please let me know if you still experience it on the new version.

Thanks.

@Yortw Yortw closed this as completed Feb 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants