Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm Delete Files #157

Closed
GV14982 opened this issue May 16, 2024 · 2 comments
Closed

Confirm Delete Files #157

GV14982 opened this issue May 16, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@GV14982
Copy link
Contributor

GV14982 commented May 16, 2024

First off, thanks so much for your hard work on this awesome tool! I'd be happy to submit a PR for this if you think it's worth it :)

The part you want to Enhancement
I think it would be a good idea if you got a confirmation modal when deleting files. I have gone to use the vim ctrl+d keybind to jump down half a page on muscle memory and accidentally deleted a file a couple times lol

Why it is necessary to enhancement
I just think anytime you're mutating the file system it's good to confirm with the user.

Additional context

@GV14982 GV14982 added the enhancement New feature or request label May 16, 2024
@yorukot
Copy link
Owner

yorukot commented May 17, 2024

This actually already update in the superfile v1.1.3!

@yorukot
Copy link
Owner

yorukot commented May 17, 2024

Screencast.from.2024-05-17.12-50-49.mp4

@GV14982 GV14982 closed this as completed May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants