Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do we really need to use react-deco? #8

Open
felixmosh opened this issue Jul 22, 2019 · 2 comments
Open

do we really need to use react-deco? #8

felixmosh opened this issue Jul 22, 2019 · 2 comments

Comments

@felixmosh
Copy link
Contributor

felixmosh commented Jul 22, 2019

First of all, thank you for this awesome lib!

This lib can be ~50% smaller by removing the dep on react-deco.

image
If you agree I will create a PR for that.

@yosbelms
Copy link
Owner

@felixmosh react-deco is the responsible of the 33.1% of the weight of this library. I wonder how smaller it will be, regarding typescript adds headers for classes and stub for method definitions when compiling to ES5, and both (Image and Defer) components are stateful.

I need more votes for this issue. Though, I'm curious to know how smaller it will be.

@yosbelms
Copy link
Owner

@felixmosh I think it is time to reopen this issue now that React hooks are adopted by the community we can get rid of react-deco PR is welcome!

@yosbelms yosbelms reopened this Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants