Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing part1 #10

Merged
merged 5 commits into from May 12, 2022
Merged

Testing part1 #10

merged 5 commits into from May 12, 2022

Conversation

bizip
Copy link
Collaborator

@bizip bizip commented May 12, 2022

What does this PR do?

  • Add tests for adding and removing list item functions

Description of Task to be completed

  • All tasks related to deployment are completed

Changes Made:

  • Installed jest and configured it with es6 modules
  • Add test suite for adding todo
  • Add test suite for removing todo

How should this be manually tested?

  1. Clone this repository and switch to testing-part1
  2. Install all required dependencies npm install
  3. Run npm test

Copy link

@zieeco zieeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

status: APPROVED 🟢 💯

Hi, @bizip

68747470733a2f2f6d656469612e67697068792e636f6d2f6d656469612f78543078657a514755357843444a754350652f67697068792e676966

Good job so far 👍 Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights ⚡

✅ Descriptive PR 👍
✅ Nice design 🔥
✅ Tests are passing 🔥
✅ Good commit messages 👍
✅ Linters are passing 👏

Optional suggestions

  • N/A

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@yosefHesham yosefHesham merged commit 5ff62af into main May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants