Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deny multiple versions of dependencies #83

Merged
merged 1 commit into from Dec 17, 2022

Conversation

fredr
Copy link
Contributor

@fredr fredr commented Dec 16, 2022

This will cause CI to fail if multiple versions of a dependency is being used. This will prevent that someone accidentally adds several versions of a dependency.

In some cases there is no solution to having multiple versions, and in those cases an exception can be added in deny.yaml,
I've added an exception for windows-sys where there is currently two versions in the dependency graph.

@yoshidan yoshidan added safe to test safe to test and removed safe to test safe to test labels Dec 17, 2022
@yoshidan
Copy link
Owner

The cause of CI / common is latest clippy.
Please merge the main branch as it has been fixed in #84 .

@fredr fredr force-pushed the fredr/deny-multiple-versions branch from 3aec0ea to e754269 Compare December 17, 2022 12:02
@fredr
Copy link
Contributor Author

fredr commented Dec 17, 2022

👍 I've rebased with main now

@yoshidan yoshidan added safe to test safe to test and removed safe to test safe to test labels Dec 17, 2022
@yoshidan yoshidan merged commit a7d8fb2 into yoshidan:main Dec 17, 2022
@fredr fredr deleted the fredr/deny-multiple-versions branch December 17, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test safe to test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants