Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: set pipefail option in test script #360

Merged
merged 2 commits into from Jan 7, 2017
Merged

tests: set pipefail option in test script #360

merged 2 commits into from Jan 7, 2017

Conversation

bendrucker
Copy link
Contributor

Closes #356

@bendrucker bendrucker mentioned this pull request Dec 12, 2016
Closed
@bendrucker
Copy link
Contributor Author

Tests are expected to fail, pending #358

@bendrucker
Copy link
Contributor Author

Two changes here actually. Had to update the shebang to use bash instead of sh so pipefail is available.

@yoshuawuyts
Copy link
Member

yay, thanks Ben 🎉

@yoshuawuyts yoshuawuyts merged commit 8ea87bc into choojs:master Jan 7, 2017
@yoshuawuyts yoshuawuyts mentioned this pull request Jan 7, 2017
Closed
@bendrucker bendrucker deleted the pipefail branch January 7, 2017 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bendrucker @yoshuawuyts