Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed extremely slow Array.prototype.slice from hot path #46

Merged
merged 1 commit into from
Oct 5, 2016

Conversation

mcollina
Copy link
Contributor

@mcollina mcollina commented Oct 5, 2016

As titled :).

Where I am using this I got a a 10-20% throughput improvement with this change.

I'll ping you when I have something more solid on where I am using this.

@coveralls
Copy link

coveralls commented Oct 5, 2016

Coverage Status

Coverage increased (+0.08%) to 95.96% when pulling 821eb96 on mcollina:master into 20f1dc5 on yoshuawuyts:master.

@yoshuawuyts
Copy link
Member

This is great!

@yoshuawuyts yoshuawuyts merged commit 8986a3c into choojs:master Oct 5, 2016
@yoshuawuyts
Copy link
Member

Released as v6.2.2 🎉 🎉 🎉 🎉

@a0viedo
Copy link

a0viedo commented Dec 6, 2016

@mcollina not seeing this in arbitrary big arrays (40M items) in latest versions of V8 (issue). I'll benchmark it in a few other engines and see what the results are.

@mcollina
Copy link
Contributor Author

mcollina commented Dec 6, 2016

@a0viedo the problem is the use of arguments, not slice(). Your examples consider big arrays, but arguments is not an array.

@a0viedo
Copy link

a0viedo commented Dec 6, 2016

oh I see!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants