New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix callback parameter mutation #66

Merged

yoshuawuyts merged 1 commit into choojs:master from tornqvist:fix-callback-mutation

Feb 21, 2018

Member

tornqvist commented Feb 15, 2018

Reusing the same callback for two routes would overwrite cb.route each time resulting in a false match for the first route.

Though arguably an edge case, mutating parameters does make for unexpected behavior.


          Fix callback parameter mutation

6ef24b8

yoshuawuyts approved these changes

View reviewed changes

Member

yoshuawuyts left a comment

LGTM

yoshuawuyts merged commit ff25c87 into choojs:master

tornqvist deleted the fix-callback-mutation branch

February 21, 2018 13:12

tornqvist mentioned this pull request

Store route on trie node #67

Merged

tornqvist mentioned this pull request

[feat] allow same cbs on different routes #68

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment