Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #66 in favor of storing the route on the trie node. Using a proxy callback worked for mitigating the immediate problem with reusing route callbacks but it also makes it difficult to register anything other than functions as route callbacks.
I.e. if I was to register a class as a route callback I'd probably want that class returned from
.match
and not a wrapper function. This is relevant if you'd want to register top level components as routes in choo.This does however break the undocumented functionality of accessing the route on
this
in the callback. I dunno what that means for semver 馃