[feat] allow same cbs on different routes #68
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue where
all end up returning the route as c because wayfarer sticks the route on the reference. which in turn puts the wrong data in state.route as they all resolve to the last known route appended to the callback.
The solution proposed herein simply clones the callback cleanly and thus the trie code doesn't need to be modified. The alternative is to modify trie which is a bit more complex. This is the simplest solution i can think of. Related to #67
@yoshuawuyts @tornqvist