You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems that the line descriptor is not updated at each iteration, since the output of the desc_layer has a different name than the input (desc vs enc_output). This does not trigger any error from the compiler, but the effect is that only one iteration of desc_layers is effectively used... The previous iterations are just overwritten each time.
Let me know if I got a wrong understanding of this line. Otherwise I think that the correction would be the following:
for desc_layer in self.desc_layers:
desc, enc_slf_attn = desc_layer(desc, slf_attn_mask=mask)
enc_slf_attn_list += [enc_slf_attn] if return_attns else []
enc_output = desc
The text was updated successfully, but these errors were encountered:
an nyeong ha se yo,jeon neun maeng rui im ni da,when im learning the NLP in my projects, i found your paper is a new way in visual detect ,im trying to learn your code ,thank you for your sharing!
Hi @yosungho,
Thanks for this very nice work and for sharing the code, it is very insightful!
When studying the code, I noticed something weird that might be a bug. It is located in the KeylineEncoder at line:
LineTR/models/line_transformer.py
Line 121 in afd89ef
It seems that the line descriptor is not updated at each iteration, since the output of the desc_layer has a different name than the input (desc vs enc_output). This does not trigger any error from the compiler, but the effect is that only one iteration of desc_layers is effectively used... The previous iterations are just overwritten each time.
Let me know if I got a wrong understanding of this line. Otherwise I think that the correction would be the following:
The text was updated successfully, but these errors were encountered: