Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions: All generate test failed #1149

Closed
HeRaNO opened this issue May 11, 2024 · 3 comments · Fixed by #1161
Closed

Actions: All generate test failed #1149

HeRaNO opened this issue May 11, 2024 · 3 comments · Fixed by #1161
Assignees

Comments

@HeRaNO
Copy link
Contributor

HeRaNO commented May 11, 2024

I noticed that the CI All generate test fails from Actions #216. After diving into it, I found that:

  1. problem.py emits lots of warning as this comment shows, it's caused by stdout=open(...) and many more likewise code.
  2. Since this actions, macOS workflow updates from macOS 12.7.4 to macOS 14.4.1, causing a clang version update (but I'm not sure which version is updated to since I don't have a macOS device 😢 ) (14.0.0 to 14.0.3, see here), and now we are using ARM version, but maybe x86 before. Log shows that some of codes in AtCoder Library fails on compile stage:
2024-05-09T00:38:40.1389120Z math/compositional_inverse_of_formal_power_series_large/sol/small_correct.cpp:782:25: error: unqualified call to 'std::move' [-Werror,-Wunqualified-std-cast-call]
2024-05-09T00:38:40.1390160Z   auto c2 = convolution(move(a2), move(b2));
2024-05-09T00:38:40.1390540Z                         ^
2024-05-09T00:38:40.1390850Z                         std::
2024-05-09T00:38:40.1392120Z math/compositional_inverse_of_formal_power_series_large/sol/small_correct.cpp:808:13: note: in instantiation of function template specialization 'atcoder::convolution<754974721U, long long, nullptr>' requested here
2024-05-09T00:38:40.1394230Z   auto c1 = convolution<MOD1>(a, b);
2024-05-09T00:38:40.1394550Z             ^
2024-05-09T00:38:40.1395400Z math/compositional_inverse_of_formal_power_series_large/sol/small_correct.cpp:782:35: error: unqualified call to 'std::move' [-Werror,-Wunqualified-std-cast-call]
2024-05-09T00:38:40.1396280Z   auto c2 = convolution(move(a2), move(b2));
2024-05-09T00:38:40.1396710Z                                   ^
2024-05-09T00:38:40.1397060Z                                   std::
2024-05-09T00:38:40.1612440Z math/compositional_inverse_of_formal_power_series_large/sol/small_correct.cpp:782:25: error: unqualified call to 'std::move' [-Werror,-Wunqualified-std-cast-call]
2024-05-09T00:38:40.1613320Z   auto c2 = convolution(move(a2), move(b2));
2024-05-09T00:38:40.1613630Z                         ^
2024-05-09T00:38:40.1613890Z                         std::
2024-05-09T00:38:40.1614900Z math/compositional_inverse_of_formal_power_series_large/sol/small_correct.cpp:809:13: note: in instantiation of function template specialization 'atcoder::convolution<167772161U, long long, nullptr>' requested here
2024-05-09T00:38:40.1616500Z   auto c2 = convolution<MOD2>(a, b);
2024-05-09T00:38:40.1616850Z             ^
2024-05-09T00:38:40.1617640Z math/compositional_inverse_of_formal_power_series_large/sol/small_correct.cpp:782:35: error: unqualified call to 'std::move' [-Werror,-Wunqualified-std-cast-call]
2024-05-09T00:38:40.1618730Z   auto c2 = convolution(move(a2), move(b2));
2024-05-09T00:38:40.1619000Z                                   ^
2024-05-09T00:38:40.1619400Z                                   std::
2024-05-09T00:38:40.1801880Z math/compositional_inverse_of_formal_power_series_large/sol/small_correct.cpp:782:25: error: unqualified call to 'std::move' [-Werror,-Wunqualified-std-cast-call]
2024-05-09T00:38:40.1802650Z   auto c2 = convolution(move(a2), move(b2));
2024-05-09T00:38:40.1802920Z                         ^
2024-05-09T00:38:40.1803130Z                         std::
2024-05-09T00:38:40.1804070Z math/compositional_inverse_of_formal_power_series_large/sol/small_correct.cpp:810:13: note: in instantiation of function template specialization 'atcoder::convolution<469762049U, long long, nullptr>' requested here
2024-05-09T00:38:40.1804930Z   auto c3 = convolution<MOD3>(a, b);
2024-05-09T00:38:40.1805170Z             ^
2024-05-09T00:38:40.1805880Z math/compositional_inverse_of_formal_power_series_large/sol/small_correct.cpp:782:35: error: unqualified call to 'std::move' [-Werror,-Wunqualified-std-cast-call]
2024-05-09T00:38:40.1806620Z   auto c2 = convolution(move(a2), move(b2));
2024-05-09T00:38:40.1807230Z                                   ^
2024-05-09T00:38:40.1807480Z                                   std::
2024-05-09T00:38:40.2262490Z 6 errors generated.
  1. version.json cache save fails on macOS and Windows CI. I'm not sure whether it is important. Check Actions #215 to see this issue. It's a fake issue. Daily generate test will hit the cache of diff generate test.
Run actions/cache/save@v3
  with:
    path: versions.json
    key: macOS-(clang++)-versions-cache-ce9908c017ea05051c865095a6aafe4cad7abc[2](https://github.com/yosupo06/library-checker-problems/actions/runs/8841154400/job/24277785597#step:7:2)37c93a898521c[3](https://github.com/yosupo06/library-checker-problems/actions/runs/8841154400/job/24277785597#step:7:3)98315a77cf8
    enableCrossOsArchive: false
  env:
    pythonLocation: /Users/runner/hostedtoolcache/Python/3.12.3/x6[4](https://github.com/yosupo06/library-checker-problems/actions/runs/8841154400/job/24277785597#step:7:4)
    PKG_CONFIG_PATH: /Users/runner/hostedtoolcache/Python/3.12.3/x64/lib/pkgconfig
    Python_ROOT_DIR: /Users/runner/hostedtoolcache/Python/3.12.3/x64
    Python2_ROOT_DIR: /Users/runner/hostedtoolcache/Python/3.12.3/x64
    Python3_ROOT_DIR: /Users/runner/hostedtoolcache/Python/3.12.3/x64
/usr/local/bin/gtar --posix -cf cache.tzst --exclude cache.tzst -P -C /Users/runner/work/library-checker-problems/library-checker-problems --files-from manifest.txt --delay-directory-restore --use-compress-program zstdmt
Failed to save: Unable to reserve cache with key macOS-(clang++)-versions-cache-ce9908c017ea0[5](https://github.com/yosupo06/library-checker-problems/actions/runs/8841154400/job/24277785597#step:7:5)051c865095a6aafe4cad7abc237c93a898521c398315a77cf8, another job may be creating this cache. More details: Cache already exists. Scope: refs/heads/master, Key: macOS-(clang++)-versions-cache-ce9908c017ea05051c8[6](https://github.com/yosupo06/library-checker-problems/actions/runs/8841154400/job/24277785597#step:7:6)5095a6aafe4cad[7](https://github.com/yosupo06/library-checker-problems/actions/runs/8841154400/job/24277785597#step:7:7)abc237c93a898521c398315a77cf8, Version: 87340dc5e4f156cde629870bea95be97[8](https://github.com/yosupo06/library-checker-problems/actions/runs/8841154400/job/24277785597#step:7:8)69fdb028174bcb0a2423908cd1baa11
Warning: Cache save failed.
  1. From May 15th, g++-13 has been removed from the Ubuntu 22.04 image. It will cause a fail on generate. Should upgrade to Ubuntu 24.04. See Ubuntu 22.04 (20240514) Image Update actions/runner-images#9854
@HeRaNO
Copy link
Contributor Author

HeRaNO commented May 12, 2024

For the second issue, maybe an older version of AtCoder Library is used. The mainline version of ACL won't have this issue.

@HeRaNO
Copy link
Contributor Author

HeRaNO commented May 19, 2024

@yosupo06 PTAL

@yosupo06
Copy link
Owner

thanks I upgraded to use 24.04 for g++-13 #1159

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants