Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split-brain when redis master restarted without restart of its resec #6

Closed
imcitius opened this issue Mar 19, 2018 · 1 comment
Closed

Comments

@imcitius
Copy link

imcitius commented Mar 19, 2018

Hello

I found a reproducible situation: when you stop redis process on master, it becomes red in consul, but resec do not removes it from redis-master service.
Then after redis process is restarted, healthcheck sets it to green, and we now have double master setup, with slave connected to one of them.
Restart of resec process on former master resolves issue.

resec's log output from this master:

2018/03/19 17:05:42 [ERROR] Can't connect to redis running on 127.0.0.1:6379
2018/03/19 17:05:42 [INFO] Redis HealthCheck changed to NOT healthy
2018/03/19 17:05:42 [INFO] Received update for master from consul
2018/03/19 17:05:42 [INFO] No redis master services in Consul
2018/03/19 17:05:42 [INFO] Received update for master from consul
2018/03/19 17:05:42 [INFO] Redis master updated in Consul
2018/03/19 17:05:42 [INFO] Received update for master from consul
2018/03/19 17:05:42 [INFO] No redis master services in Consul
2018/03/19 17:05:47 [INFO] Received update for master from consul
2018/03/19 17:05:47 [ERROR] Can't connect to redis running on 127.0.0.1:6379
2018/03/19 17:05:52 [INFO] Redis HealthCheck changed to healthy
2018/03/19 17:05:52 [INFO] Trying to acquire leader lock
2018/03/19 17:05:52 [INFO] Received update for master from consul
2018/03/19 17:05:52 [ERROR] Found more than one master registered in Consul

@imcitius imcitius changed the title Split brain when master restarted without restart of resec Split brain when redis master restarted without restart of its resec Mar 19, 2018
@imcitius imcitius changed the title Split brain when redis master restarted without restart of its resec Split-brain when redis master restarted without restart of its resec Mar 19, 2018
@burdandrei
Copy link
Contributor

@imcitius just saw it. Will check, Thanks!

@burdandrei burdandrei added the bug label Apr 23, 2018
@burdandrei burdandrei added this to the 0.5.0 milestone Apr 30, 2018
@jippi jippi mentioned this issue Jul 19, 2018
burdandrei pushed a commit that referenced this issue Aug 19, 2018
* Fixes #18

Signed-off-by: Christian Winther <jippignu@gmail.com>

* Fixes #6

Signed-off-by: Christian Winther <jippignu@gmail.com>

* renameing

Signed-off-by: Christian Winther <jippignu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants