Crash when opening cells in different sections

[seanonthenet]

Hi. I get a crash when trying to open expandable cells in different sections. Index out of range. Works fine when opening multiple expandable cells in the same section just not in two (or more I'm assuming) different sections. I need this to work without closing the already opened cell. Not sure how to fix this.

Simplest ViewController code below:

import UIKit
import ExpandableCell



class MyTableViewController: UIViewController {

    
    @IBOutlet var tableView: ExpandableTableView!
    
    
    var cell: UITableViewCell {
        return tableView.dequeueReusableCell(withIdentifier: ExpandedButtonCell.ID)!
    }
    
    override func viewDidLoad() {
        super.viewDidLoad()
        // Do any additional setup after loading the view, typically from a nib.
        tableView.expandableDelegate = self
        //tableView.openAll()
        tableView.register(UINib(nibName: "NormalExpandableCell", bundle: nil), forCellReuseIdentifier: NormalExpandableCell.ID)
        tableView.register(UINib(nibName: "ExpandedButtonCell", bundle: nil), forCellReuseIdentifier: ExpandedButtonCell.ID)
    }
}


extension MyTableViewController: ExpandableDelegate {
    
    
    // Number of sections
    func numberOfSections(in expandableTableView: ExpandableTableView) -> Int {
        return 2
    }
    
    // Number of rows in section
    func expandableTableView(_ expandableTableView: ExpandableTableView, numberOfRowsInSection section: Int) -> Int {
        return 2
    }
    
    // Cells for row at (returns the main top level cells)
    func expandableTableView(_ expandableTableView: ExpandableTableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {
        guard let cell = expandableTableView.dequeueReusableCell(withIdentifier: NormalExpandableCell.ID) else { return UITableViewCell() }
        return cell
    }
    
    // Expanded Cells for row
    func expandableTableView(_ expandableTableView: ExpandableTableView, expandedCellsForRowAt indexPath: IndexPath) -> [UITableViewCell]? {
        return [cell, cell, cell]
    }
    
    // height for row
    func expandableTableView(_ expandableTableView: ExpandableTableView, heightForRowAt indexPath: IndexPath) -> CGFloat {
        return 100
    }
    
    
    // heights for expanded row at
    func expandableTableView(_ expandableTableView: ExpandableTableView, heightsForExpandedRowAt indexPath: IndexPath) -> [CGFloat]? {
        return [44, 44, 44]
    }

}


// EXPANDABLE CELLS HERE
class NormalExpandableCell: ExpandableCell {
    static let ID = "NormalExpandableCell"
}


class ExpandedButtonCell: UITableViewCell {
    static let ID = "ExpandedButtonCell"

}

[seanonthenet]

Please could you let me know if it's a bug with ExpandableCell or with my implementation?

[younatics]

I will check it

[seanonthenet]

Really appreciate it. Thank-you!

[nishaddangui]

same issue here,
tried closing all cells in didSelectRowAt , now error vanished but atleast one cell is left open since there is no deselect method.

[hadiidbouk]

The problem is with the index of cells i guess, when you expand a cell the count of cells will changes.

[seanonthenet]

@hadiidbouk Yes. Not sure how to fix that though.

[younatics]

Hello @nishaddangui , @hadiidbouk @Spark3000 ,
Could you show me your project file or other demo files so I can check error/bugs?
Thanks!

[hadiidbouk]

The fact that i am working on a fork of this project to add the highlight methods, when i press on a cell the highlight will be on a wrong cell when there is a cell open, to fix the problem you can call a function after calling 'open' and 'close' in the ExpandableCell that can refresh the cells count.

[younatics]

@hadiidbouk Really appreciate if you send me PR :)

[hadiidbouk]

Sure, when i finish from it 👍

[nishaddangui]

@younatics put closeAll() right before open(indexPath: indexPath, delegate: delegate) in didSelectRow
in your ExtendableTableView class
Kinda works for me

[ilyarmnzhdn]

can you solve this issue?

[pikaboo]

I fixed this issue in one of the recent commits

[tadeha]

@pikaboo How did you fix this?
Because I have the same problem in didSelectRow function. It's returning a wrong indexPath.