Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors with SDWebImage 5.0.x #76

Open
TomMajor opened this issue May 22, 2019 · 7 comments
Open

Errors with SDWebImage 5.0.x #76

TomMajor opened this issue May 22, 2019 · 7 comments

Comments

@TomMajor
Copy link
Contributor

Using MediaBrowser in a recent project lead to 2 errors in the MediaBrowser Pod which makes further compile in the project impossible.
The 2 errors are at:

Media.swift #194
operation = SDWebImageManager.shared().loadImage(...
Cannot call value of non-function type 'SDWebImageManager'

MediaBrowser.swift #307
SDImageCache.shared().clearMemory()
Cannot call value of non-function type 'SDImageCache'

Because latest MediaBrowser release was on March 31 and SDWebImage made a major release 5.0 on April 2, I thought to give it a try with the SDWebImage version which was current when MediaBrowser 2.3.0 was reelased.
So I fixed this error with explicitly stating in the podfile to use version 4.4.6 of SDWebImage.

Would be great if this could be fixed for next release of MediaBrowser so that current SDWebImage can be used.

Thanks,

@ro8i
Copy link

ro8i commented Jun 25, 2019

+1

2 similar comments
@matheusfalcao20
Copy link

+1

@Milap-Kundalia
Copy link

+1

@f15radar
Copy link

How did you specify to use 4.4.6. I have tried and am getting

Value of type 'SDWebImageManager' has no member 'loadImage'

@TomMajor
Copy link
Contributor Author

There is a special syntax in the podfile for locking the pod to a specific version, you have to read the docs for that - I don't have my Macbook at hand.
This project seems kind of dead anyway 😿 , maybe one would better look for another media browser library?

@younatics
Copy link
Owner

I can handle PR or collaborator:).
The work is so busy that I can't care about open source.
Please request me anyway!

@TomMajor
Copy link
Contributor Author

@younatics
I just dicovered that this PR from @atulkhatri will fix this issue I raised about 1 year ago:
#83

Could you please consider to merge this and release a new version with it, so Cocoapods will pull this fix?

Also I discovered another small issue (maybe because of new iPhone screen sizes?), please see attached screenshot.
There is a small white stripe on top below the status bar, this white was the previous view, presenting the browser does not cover the full screen anymore.
Could you please hint the place in code where this view size is set, so see if I can do anything about it?
Thanks,
ScreenShot 41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants