New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code review #4

Open

youngwind opened this issue Dec 12, 2015 · 0 comments

Labels

其他

Owner

youngwind commented Dec 12, 2015

code review很难

code review很难，主要基于以下原因。

太忙了，连新需求都没完成，哪有时间review。
惯性，培养新的良好习惯是需要一番挣扎的。

但是，code review很重要

除了一般的HTML、CSS、JS规范，在进行 code review的时候还需要注意以下几点。

代码是否简单易懂？
是否存在多余或者重复的代码？
代码是否尽可能地模块化（组件化）？
是否有被注释掉的代码？
是否有可以被库函数代替的代码？
是否有可以删除的日志或调试代码？
无效的参数值是否能够处理？
……

youngwind added the 其他 label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment