Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
info button sometimes drawn off-center #575
this has always been a problem with the close-box too. however several factors contribute to make it less noticeable: it only happens in the rightmost column, the close box is lower contrast, the x being off-center is not quite as noticeable due to the small size and anti-aliasing.
the info button is more immediately visible as off center.
the problem exists because text is rendered on it's own pixel boundaries. if a stack appears on a half-pixel boundary the text will sometimes draw on one pixel and sometimes the other with respect to other dom elements like images, backgrounds, borders, etc.
i don't think there is a way to accurately align the text with the background dom elements with pixel precision. this implies that the background and foreground need to be both be glyphs or both be background dom elements.
it seems possible that the background could be a circle glyph and the foreground another glyph -- however in practice it is very difficult to center one glyph inside another as fractional transforms are not rendered.
replaced the close and info button with icons that include the background circle.
the pin button still has the same problem, but again is not quite so noticeable. i could probably replace the background with a circle glyph from the same library. i suspect this would work but since the problem is not very noticeable and that would require a significant amount of complication and more glyphs, i'm going to leave the pin as-is.
at this time there doesn't seem to be a need for a general purpose solution as there are only a few buttons we need in these cases