Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Mode Support #8

Closed
BayuAngora opened this issue Aug 4, 2019 · 15 comments · Fixed by #68
Closed

Dark Mode Support #8

BayuAngora opened this issue Aug 4, 2019 · 15 comments · Fixed by #68
Labels
enhancement New feature or request

Comments

@BayuAngora
Copy link

This theme is better if there's a dark mode button feature.

@YoussefRaafatNasry
Copy link
Owner

I will try to work on this soon,
Maybe help if you could?

@BayuAngora
Copy link
Author

This theme has simple dark mode button below.
https://webjeda.com/hagura/

@YoussefRaafatNasry YoussefRaafatNasry added the enhancement New feature or request label Jan 4, 2020
@YoussefRaafatNasry YoussefRaafatNasry changed the title Dark Mode Feature? Dark Mode Support Jan 4, 2020
@mytahir
Copy link

mytahir commented Jun 17, 2020

really wished if this Page could had dark mode, It would look good and nicer.

@udaygirish
Copy link

udaygirish commented Aug 17, 2020

@YoussefRaafatNasry Any update on the dark mode support ? really want to see this clean web theme in dark mode!!

@BornToBeRoot
Copy link

BornToBeRoot commented Sep 4, 2020

Dark mode would be awesome. Anyway, thanks for this great project 👍

Edit: Maybe you could use this: https://github.com/sandoche/Darkmode.js

I could embed it into the site, but the color of the text does not change:

image
image

Edit 2: The option saveInCookies should be set to false by default.

@BayuAngora
Copy link
Author

Dark mode would be awesome. Anyway, thanks for this great project 👍

Edit: Maybe you could use this: https://github.com/sandoche/Darkmode.js

I could embed it into the site, but the color of the text does not change:

image
image

Edit 2: The option saveInCookies should be set to false by default.

Text in dark mode should be configure on dark mode style part.

@aman-roy
Copy link

You can use
@media(prefers-color-scheme: dark)

For more details check these changes in my own blog - aman-roy/amanroy.me@59380ca

@udaygirish
Copy link

@aman-roy That's really great and it worked for me... Thanks a lot, man!!

@aman-roy
Copy link

@udaygirish Welcome!

@udaygirish
Copy link

@aman-roy I checked my web in several Operating systems don't know whether the problem is with mine or not. But on my mac and android, it is showing in dark but not in chrome browsers in Ubuntu OS. Have you checked on this ?? Just want to know how this is happening!! I have even checked some issues regarding this but still, it seems it is not resolved yet !! Any idea about this?

@aman-roy
Copy link

aman-roy commented Sep 13, 2020

@udaygirish, I use Ubuntu 20.04 as my main driver. I also use chrome for browsing. Unfortunately, there is no support for dark mode in chrome. But don't worry I will help you out in that. But the solution is quite experimental. It has not been incorporated completely into chrome.

Solution

Step 1: Open chrome.
Step 2: Write chrome://flags/#enable-force-dark into URL address bar.
Step 3: Enable the very first option.
Screenshot from 2020-09-13 06-46-27


Step 4: Relaunch.
Step 5: Go to http://udaygirish.github.io and check for yourself. It's done!

@bitcoinstart
Copy link

would like a button on the page for dark mode

YoussefRaafatNasry added a commit that referenced this issue May 4, 2021
YoussefRaafatNasry added a commit that referenced this issue May 4, 2021
@YoussefRaafatNasry
Copy link
Owner

Dark theme is avilable now guys! 🥳

First of all, I need to apologize for this taking more much much more than it should. And as we developers are addicted to dark themes, I decided it's time to implement this.

I tried the solution proposed by @BornToBeRoot, but the result's were as good as I expected, even after fixing the issues that were introduced by Darkmode.js.

So I ended up using ForEvolve/bootstrap-dark and modyifying it a teeny tiny bit to match the theme style. I might have missed something or two, but I will fix them as soon as I have more time. Don't feel hesitated to report those bugs.

@udaygirish
Copy link

Thank you!

@YoussefRaafatNasry
Copy link
Owner

Dark theme was completely reworked in 45da384 for better loading time and color palette.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants