Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 'CallbackReturn' does not name a type #24

Merged
merged 1 commit into from
Sep 15, 2022
Merged

fix 'CallbackReturn' does not name a type #24

merged 1 commit into from
Sep 15, 2022

Conversation

ijnek
Copy link
Member

@ijnek ijnek commented Sep 11, 2022

Building on rolling, (and perhaps humble too), the following error shows up:

/home/ijnek/tmp_workspaces/dynamixel_control_ws/src/dynamixel_control/dynamixel_hardware/src/dynamixel_hardware.cpp:51:1: error: ‘CallbackReturn’ does not name a type
   51 | CallbackReturn DynamixelHardware::on_init(const hardware_interface::HardwareInfo & info)
      | ^~~~~~~~~~~~~~

This change fixes this error.

Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
@youtalk youtalk changed the base branch from main to rolling September 15, 2022 11:48
@youtalk
Copy link
Collaborator

youtalk commented Sep 15, 2022

Thank you for your PR. I really appreciate it but I cannot try the PR on ROS 2 Rolling environment right now.
That's why I've changed the merge branch from the main to the rolling.
After testing in my environment, I promise to merge to the main branch. Thank you again.

@ijnek
Copy link
Member Author

ijnek commented Sep 16, 2022

Hi @youtalk, thank you for your existing work and the ongoing maintenance!

@ijnek ijnek deleted the ijnek-add-callbackreturn-reference branch September 16, 2022 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants