Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unused parameter (just rolling branch) #31

Merged
merged 3 commits into from
Sep 24, 2022
Merged

Fix unused parameter (just rolling branch) #31

merged 3 commits into from
Sep 24, 2022

Conversation

ijnek
Copy link
Member

@ijnek ijnek commented Sep 21, 2022

This fixes the following unused parameter warnings specific to the rolling branch:

/home/ijnek/tmp_workspaces/quasor_ws/src/dynamixel_control/dynamixel_hardware/src/dynamixel_hardware.cpp: In member function ‘virtual hardware_interface::return_type dynamixel_hardware::DynamixelHardware::read(const rclcpp::Time&, const rclcpp::Duration&)’:
/home/ijnek/tmp_workspaces/quasor_ws/src/dynamixel_control/dynamixel_hardware/src/dynamixel_hardware.cpp:242:58: warning: unused parameter ‘time’ [-Wunused-parameter]
  242 | return_type DynamixelHardware::read(const rclcpp::Time & time, const rclcpp::Duration & period)
      |                                     ~~~~~~~~~~~~~~~~~~~~~^~~~
/home/ijnek/tmp_workspaces/quasor_ws/src/dynamixel_control/dynamixel_hardware/src/dynamixel_hardware.cpp:242:89: warning: unused parameter ‘period’ [-Wunused-parameter]
  242 | turn_type DynamixelHardware::read(const rclcpp::Time & time, const rclcpp::Duration & period)
      |                                                              ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~

/home/ijnek/tmp_workspaces/quasor_ws/src/dynamixel_control/dynamixel_hardware/src/dynamixel_hardware.cpp: In member function ‘virtual hardware_interface::return_type dynamixel_hardware::DynamixelHardware::write(const rclcpp::Time&, const rclcpp::Duration&)’:
/home/ijnek/tmp_workspaces/quasor_ws/src/dynamixel_control/dynamixel_hardware/src/dynamixel_hardware.cpp:291:59: warning: unused parameter ‘time’ [-Wunused-parameter]
  291 | return_type DynamixelHardware::write(const rclcpp::Time & time, const rclcpp::Duration & period)
      |                                      ~~~~~~~~~~~~~~~~~~~~~^~~~
/home/ijnek/tmp_workspaces/quasor_ws/src/dynamixel_control/dynamixel_hardware/src/dynamixel_hardware.cpp:291:90: warning: unused parameter ‘period’ [-Wunused-parameter]
  291 | urn_type DynamixelHardware::write(const rclcpp::Time & time, const rclcpp::Duration & period)
      |                                                              ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~

Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
@ijnek ijnek changed the base branch from main to rolling September 21, 2022 05:52
Copy link
Collaborator

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are minor modifications. I think we will use them in the future.

dynamixel_hardware/src/dynamixel_hardware.cpp Outdated Show resolved Hide resolved
dynamixel_hardware/src/dynamixel_hardware.cpp Outdated Show resolved Hide resolved
ijnek and others added 2 commits September 24, 2022 06:52
Co-authored-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Co-authored-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Copy link
Collaborator

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@youtalk youtalk merged commit dcfd8b9 into dynamixel-community:rolling Sep 24, 2022
@ijnek ijnek deleted the ijnek-unused-parameter-2 branch September 24, 2022 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants